test/e2e/memcached_test.go: fix travis on master #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On master, TRAVIS_PULL_REQUEST_SLUG is still set, but to "". This breaks dep if it is run after a dependency change occurs, which happens once we add the test directory. To fix this, we check if TRAVIS_PULL_REQUEST_SLUG is "" and we also only run `dep ensure` once after all the files are up to date instead of once before and once after.
openshift-ci-robot
added
the
size/M
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master,
TRAVIS_PULL_REQUEST_SLUGis still set, but to"". Thisbreaks dep if it is run after a dependency change occurs, which
happens once we add the test directory. To fix this, we check
if
TRAVIS_PULL_REQUEST_SLUGis""and we also only rundep ensureonce after all the files are up to date instead of once before
and once after.
/cc hasbro17