pkg/ansible,*: Adding ability to specify re-queue period per GVK via watches file. #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
changed the title
shawn-hurley
added
the
language/ansible
shawn-hurley
force-pushed
the
feature/controller-specific-requeue-duration
branch
from
cd74819 to
bc9108f
Compare
openshift-ci-robot
added
the
size/L
shawn-hurley
force-pushed
the
feature/controller-specific-requeue-duration
branch
from
bc9108f to
acffc9c
Compare
shawn-hurley
changed the title
mhrivnak
suggested changes
Oct 23, 2018
pkg/ansible/runner/runner.go
Outdated
| if w.ReconcilePeriod != "" { | ||
| d, err := time.ParseDuration(w.ReconcilePeriod) | ||
| if err != nil { | ||
| logrus.Warningf("unable to parse duration: %v - %v, setting to default", w.ReconcilePeriod, err) |
There was a problem hiding this comment.
If someone tries to set this but screws it up, I think it's better to fail to make sure they know and fix it.
| @@ -66,7 +67,7 @@ func main() { | |||
| } | |||
|
|
|||
| // start the operator | |||
| go operator.Run(done, mgr, "/opt/ansible/watches.yaml") | |||
| go operator.Run(done, mgr, "/opt/ansible/watches.yaml", 5*time.Second) | |||
There was a problem hiding this comment.
Should this be one minute, to match what up local does? I also thought we'd generally settled on a minute as roughly the right default period.
shawn-hurley
force-pushed
the
feature/controller-specific-requeue-duration
branch
from
acffc9c to
98bbf38
Compare
mhrivnak
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding ability to specify GVK specific re-queue times via the watches file
Motivation for the change: