Skip to content

Release versioning #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Fix the release.sh file and improve the versioning documentation.

Motivation for the change: We need the release.sh to be correct to make new releases and we need working documentation for maintainers who have not done releases in the past.

@AlexNPavel AlexNPavel requested review from hasbro17 and estroz October 31, 2018 22:31
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2018
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasbro17
Copy link
Contributor

hasbro17 commented Nov 1, 2018

We also might want to turn the "untracked and uncommited files" errors into warnings since it stops us from running the release script if we make some last minute local changes.

@AlexNPavel AlexNPavel merged commit e63ba2f into operator-framework:master Nov 1, 2018
@AlexNPavel AlexNPavel deleted the release-versioning branch November 1, 2018 18:00
AlexNPavel added a commit to AlexNPavel/operator-sdk that referenced this pull request Nov 2, 2018
* release.sh: fix TOML_TMPL_FILE path

* doc/release-versioning.md: update release versioning doc
AlexNPavel added a commit that referenced this pull request Nov 2, 2018
* pkg/scaffold: remove TODO for metrics port (#679)

* pkg/scaffold: fix hardcoded crd version (#690)

Have CRD and CR examples match, so examples work
for new users.

Fixes #689

* Release versioning (#684)

* release.sh: fix TOML_TMPL_FILE path

* doc/release-versioning.md: update release versioning doc

* pkg/scaffold/gopkgtoml,version: update branch to v0.1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants