-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix sed issue on OSX #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sed issue on OSX #699
Conversation
On OSX `sed` throws an error if you do not specify a file extension when `-i` is given. Fixing the docs to address this on OSX. ``` -i extension Edit files in-place, saving backups with the specified extension. If a zero-length extension is given, no backup will be saved. It is not recommended to give a zero-length extension when in-place editing files, as you risk corruption or partial content in situations where disk space is exhausted, etc. ```
Hi @embano1. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after wording changes.
Co-Authored-By: embano1 <[email protected]>
Co-Authored-By: embano1 <[email protected]>
Co-Authored-By: embano1 <[email protected]>
Co-Authored-By: embano1 <[email protected]>
LGTM. Thanks @embano1! |
This reverts commit bd6ea65.
On OSX
sed
throws an error if you do not specify a file extension when-i
is given. Fixing the docs to address this on OSX.Error:
sed: 1: "deploy/operator.yaml": extra characters at the end of d command
From
man sed
on OSX: