Skip to content

Fix sed issue on OSX #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2018
Merged

Fix sed issue on OSX #699

merged 5 commits into from
Nov 8, 2018

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Nov 4, 2018

On OSX sed throws an error if you do not specify a file extension when
-i is given. Fixing the docs to address this on OSX.

Error:

sed: 1: "deploy/operator.yaml": extra characters at the end of d command

From man sed on OSX:

-i extension
             Edit files in-place, saving backups with the specified
	     extension.  If a zero-length extension is given, no backup
	     will be saved.  It is not recommended to give a
	                  zero-length extension when in-place editing
			  files, as you risk corruption or partial
			  content in situations where disk space is
			  exhausted, etc.

On OSX `sed` throws an error if you do not specify a file extension when
`-i` is given. Fixing the docs to address this on OSX.

```
-i extension
             Edit files in-place, saving backups with the specified
	     extension.  If a zero-length extension is given, no backup
	     will be saved.  It is not recommended to give a
	                  zero-length extension when in-place editing
			  files, as you risk corruption or partial
			  content in situations where disk space is
			  exhausted, etc.
```
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2018
@openshift-ci-robot
Copy link

Hi @embano1. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2018
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after wording changes.

@estroz estroz self-requested a review November 8, 2018 18:51
@estroz
Copy link
Member

estroz commented Nov 8, 2018

LGTM. Thanks @embano1!

@estroz estroz merged commit bd6ea65 into operator-framework:master Nov 8, 2018
shawn-hurley pushed a commit that referenced this pull request Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants