Skip to content

pkg/scaffold: Fix logging bug in controller #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

lilic
Copy link
Member

@lilic lilic commented Nov 15, 2018

Description of the change:
Fix inccorect initialization of logs in the generated controller.

Closes #748

@lilic lilic requested a review from estroz November 15, 2018 15:05
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2018
Copy link
Member

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilic lilic merged commit d6f84b4 into operator-framework:master Nov 15, 2018
@lilic lilic deleted the lili/fix-log branch November 15, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants