-
Notifications
You must be signed in to change notification settings - Fork 1.8k
doc/user/unit-testing.md: explain fake client and unit test example #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4c5a6e
to
0459cad
Compare
The unit test here is less thorough than that in |
hasbro17
reviewed
Nov 27, 2018
hasbro17
reviewed
Nov 27, 2018
hasbro17
reviewed
Nov 27, 2018
hasbro17
reviewed
Nov 27, 2018
hasbro17
reviewed
Nov 27, 2018
hasbro17
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/testing
Issue related to testing the operator-sdk and subcomponents
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: doc on using
controller-runtime
's fake client library to mock API calls in unit tests.Motivation for the change: users should be writing unit tests for custom operator code. The fake client is useful for doing so.