test/e2e/memcached_test.go: make tests work on forks #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexNPavel
requested review from
mhrivnak,
joelanford,
shawn-hurley,
lilic,
hasbro17 and
estroz
openshift-ci-robot
added
the
size/S
The extra newline was added just to create a new commit to trigger travis. Removing it because we don't need it
|
You can see the builds for the fork here: https://travis-ci.org/AlexNPavel/operator-sdk/builds Also, I enabled verbose mode on the e2e go test so we can see the output. This way we can check that the Gopkg file is unmodified when running within the repo after this is merged |
hasbro17
reviewed
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: This PR makes travis builds work correctly on forks of the sdk repo
Motivation for the change: This allows developers to test their changes in their own forks before making a PR. This was previously implemented in #766, but it caused the Gopkg.lock replacement to also occur on this repo's branches, which could mask typos in the generated Gopkg.lock. This PR includes a check to make sure it does not run for branches in this repo.
Closes #805