adding localisation support - merging into 23.0 release branch #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
naren2605
force-pushed
the
localisation-23.0
branch
from
6407e34 to
d2a3476
Compare
Achal1607
requested review from
lahodaj and
sid-srini
and removed request for
lahodaj
sid-srini
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Thank you very much @naren2605. This is a big chunk of work you have done in this PR.
Please address some of the minor misses I have commented on inline. Thanks.
|
thanks for reviewing @Achal1607 & @sid-srini will take a look and address these comments |
sid-srini
reviewed
Sep 6, 2024
naren2605
force-pushed
the
localisation-23.0
branch
3 times, most recently
from
bb5645f to
4f29479
Compare
naren2605
force-pushed
the
localisation-23.0
branch
from
4f29479 to
ac4a12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localisation enhancement -#253
for simplified chinese and japanese