Upgrade to NB-23 #256
Merged
Upgrade to NB-23 #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
requested review from
sid-srini and
lahodaj
and removed request for
sid-srini
sid-srini
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks @Achal1607 and @lahodaj for this big task done.
I've added 1 minor comment which brings a fix done in extension.ts.
Otherwise, all good.
Achal1607
force-pushed
the
nb-23-upgrade
branch
from
b865a25 to
7c8df21
Compare
|
@sid-srini I have tried to address the review comments. Thanks |
sid-srini
added a commit
to sid-srini/javavscode
that referenced
this pull request
Sep 9, 2024
Awaiting BA for NB-rc3. That will be merged via PR oracle#259. This reverts commit a6ce838, reversing changes made to b124094. Signed-off-by: Siddharth Srinivasan <[email protected]>
Merged
sid-srini
added a commit
to sid-srini/javavscode
that referenced
this pull request
Sep 9, 2024
with reapplied nb23_rc2 base upgrade 1. Reapplied the nb23-rc2 base upgrade ignoring the revert done via oracle#260. i.e. this reverts the revert-commit 97dd6cc. 2. Restored the change done in oracle#256 to add hints and errors support to the extension frontend with NB23 changes. Signed-off-by: Siddharth Srinivasan <[email protected]>
Achal1607
pushed a commit
that referenced
this pull request
Sep 9, 2024
Awaiting BA for NB-rc3. That will be merged via PR #259. This reverts commit a6ce838, reversing changes made to b124094. Signed-off-by: Siddharth Srinivasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following updates: