Doing some code cleanup and refactoring #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
lahodaj
approved these changes
Sep 13, 2024
sid-srini
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks @Achal1607.
This is very useful for me to differentiate where the COMMAND_PREFIX is required and where the languageId/clientId.
Also, the apply patches failure is great to have.
Achal1607
force-pushed
the
code-cleanup
branch
from
bc9126e to
bf41231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated NOTICE with appropriate copyright info.
Updated build script so that false
BUILD SUCCESSFULon apply-patches is fixedBefore
Now
In
extension.tsproperly prefixed some commands and removed redundant configurations.