Skip to content

[JAVSCODE-253] enabling nb support for localisation #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

naren2605
Copy link
Member

@naren2605 naren2605 commented Sep 16, 2024

enabling nb support for localisation #253

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 16, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bringing netbeans localisation to the extension is a big enhancement. Thanks a lot @naren2605.

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add update in THIRD_PARTY_LICENSE.txt as well?

Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using currently following clusters from NetBeans. So maybe we can include only these cluster paths

    ${nbplatform.active.dir}/extide:
    ${nbplatform.active.dir}/harness:
    ${nbplatform.active.dir}/ide:
    ${nbplatform.active.dir}/java:
    ${nbplatform.active.dir}/nb:
    ${nbplatform.active.dir}/platform:
    ${nbplatform.active.dir}/webcommon

@naren2605 naren2605 changed the title [JAVSCODE-253] enabling nb support for localisation [JAVSCODE-253] enabling nb support for localisation - DONOT MERGE Sep 17, 2024
[JAVSCODE-253] enabling nb support for localisation
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @naren2605

@Achal1607 Achal1607 added the do not merge Don't merge PR label Sep 17, 2024
@Achal1607 Achal1607 changed the title [JAVSCODE-253] enabling nb support for localisation - DONOT MERGE [JAVSCODE-253] enabling nb support for localisation Sep 17, 2024
@sid-srini sid-srini merged commit 5425193 into oracle:23.0.0 Sep 17, 2024
3 checks passed
@sid-srini sid-srini removed the do not merge Don't merge PR label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants