-
Notifications
You must be signed in to change notification settings - Fork 43
[JAVSCODE-253] enabling nb support for localisation #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bringing netbeans localisation to the extension is a big enhancement. Thanks a lot @naren2605.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add update in THIRD_PARTY_LICENSE.txt
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using currently following clusters from NetBeans. So maybe we can include only these cluster paths
${nbplatform.active.dir}/extide:
${nbplatform.active.dir}/harness:
${nbplatform.active.dir}/ide:
${nbplatform.active.dir}/java:
${nbplatform.active.dir}/nb:
${nbplatform.active.dir}/platform:
${nbplatform.active.dir}/webcommon
[JAVSCODE-253] enabling nb support for localisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @naren2605
enabling nb support for localisation #253