Skip to content

Adding netbeans and netbeans-l10n as submodules #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

shivam71
Copy link
Member

Added netbeans and l10n as submodules and made required changes to support them.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 16, 2024
netbeans Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naren2605 Here the commit hash is stored

@naren2605
Copy link
Member

LGTM

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shivam71 for improving the build experience and reducing human error in setup by getting this done. LGTM

@sid-srini sid-srini merged commit c383a6e into oracle:main Oct 21, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants