Skip to content

Commit 0011d2d

Browse files
Daniel Mackenomsg
authored andcommitted
power_supply: Add support for writeable properties
This patch adds support for writeable power supply properties and exposes them as writeable to sysfs. A power supply implementation must implement two new function calls in order to use that feature: int set_property(struct power_supply *psy, enum power_supply_property psp, const union power_supply_propval *val); int property_is_writeable(struct power_supply *psy, enum power_supply_property psp); Signed-off-by: Daniel Mack <[email protected]> Cc: David Woodhouse <[email protected]> Cc: Alexey Starikovskiy <[email protected]> Cc: Len Brown <[email protected]> Cc: Mark Brown <[email protected]> Cc: Matt Reimer <[email protected]> Cc: Evgeniy Polyakov <[email protected]> Cc: Tejun Heo <[email protected]> Signed-off-by: Anton Vorontsov <[email protected]>
1 parent 5f487cd commit 0011d2d

File tree

2 files changed

+40
-3
lines changed

2 files changed

+40
-3
lines changed

drivers/power/power_supply_sysfs.c

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
{ \
3434
.attr = { .name = #_name }, \
3535
.show = power_supply_show_property, \
36-
.store = NULL, \
36+
.store = power_supply_store_property, \
3737
}
3838

3939
static struct device_attribute power_supply_attrs[];
@@ -99,6 +99,29 @@ static ssize_t power_supply_show_property(struct device *dev,
9999
return sprintf(buf, "%d\n", value.intval);
100100
}
101101

102+
static ssize_t power_supply_store_property(struct device *dev,
103+
struct device_attribute *attr,
104+
const char *buf, size_t count) {
105+
ssize_t ret;
106+
struct power_supply *psy = dev_get_drvdata(dev);
107+
const ptrdiff_t off = attr - power_supply_attrs;
108+
union power_supply_propval value;
109+
long long_val;
110+
111+
/* TODO: support other types than int */
112+
ret = strict_strtol(buf, 10, &long_val);
113+
if (ret < 0)
114+
return ret;
115+
116+
value.intval = long_val;
117+
118+
ret = psy->set_property(psy, off, &value);
119+
if (ret < 0)
120+
return ret;
121+
122+
return count;
123+
}
124+
102125
/* Must be in the same order as POWER_SUPPLY_PROP_* */
103126
static struct device_attribute power_supply_attrs[] = {
104127
/* Properties of type `int' */
@@ -159,8 +182,17 @@ static mode_t power_supply_attr_is_visible(struct kobject *kobj,
159182
int i;
160183

161184
for (i = 0; i < psy->num_properties; i++) {
162-
if (psy->properties[i] == attrno)
163-
return 0444;
185+
int property = psy->properties[i];
186+
187+
if (property == attrno) {
188+
mode_t mode = S_IRUSR | S_IRGRP | S_IROTH;
189+
190+
if (psy->property_is_writeable &&
191+
psy->property_is_writeable(psy, property) > 0)
192+
mode |= S_IWUSR;
193+
194+
return mode;
195+
}
164196
}
165197

166198
return 0;

include/linux/power_supply.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,11 @@ struct power_supply {
145145
int (*get_property)(struct power_supply *psy,
146146
enum power_supply_property psp,
147147
union power_supply_propval *val);
148+
int (*set_property)(struct power_supply *psy,
149+
enum power_supply_property psp,
150+
const union power_supply_propval *val);
151+
int (*property_is_writeable)(struct power_supply *psy,
152+
enum power_supply_property psp);
148153
void (*external_power_changed)(struct power_supply *psy);
149154
void (*set_charged)(struct power_supply *psy);
150155

0 commit comments

Comments
 (0)