Skip to content

Commit 01950a3

Browse files
ebiggersAl Viro
authored andcommitted
fs/buffer.c: fold init_buffer() into init_page_buffers()
Since commit e760040 ("fs/buffer.c: remove unnecessary init operation after allocating buffer_head"), there are no callers of init_buffer() outside of init_page_buffers(). So just fold it into init_page_buffers(). Signed-off-by: Eric Biggers <[email protected]> Signed-off-by: Al Viro <[email protected]>
1 parent 4bfd054 commit 01950a3

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

fs/buffer.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,6 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
5353

5454
#define BH_ENTRY(list) list_entry((list), struct buffer_head, b_assoc_buffers)
5555

56-
void init_buffer(struct buffer_head *bh, bh_end_io_t *handler, void *private)
57-
{
58-
bh->b_end_io = handler;
59-
bh->b_private = private;
60-
}
61-
EXPORT_SYMBOL(init_buffer);
62-
6356
inline void touch_buffer(struct buffer_head *bh)
6457
{
6558
trace_block_touch_buffer(bh);
@@ -922,7 +915,8 @@ init_page_buffers(struct page *page, struct block_device *bdev,
922915

923916
do {
924917
if (!buffer_mapped(bh)) {
925-
init_buffer(bh, NULL, NULL);
918+
bh->b_end_io = NULL;
919+
bh->b_private = NULL;
926920
bh->b_bdev = bdev;
927921
bh->b_blocknr = block;
928922
if (uptodate)

include/linux/buffer_head.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ void buffer_check_dirty_writeback(struct page *page,
151151

152152
void mark_buffer_dirty(struct buffer_head *bh);
153153
void mark_buffer_write_io_error(struct buffer_head *bh);
154-
void init_buffer(struct buffer_head *, bh_end_io_t *, void *);
155154
void touch_buffer(struct buffer_head *bh);
156155
void set_bh_page(struct buffer_head *bh,
157156
struct page *page, unsigned long offset);

0 commit comments

Comments
 (0)