Skip to content

Commit 01f52e1

Browse files
davidltpaul-walmsley-sifive
authored andcommitted
riscv: define vmemmap before pfn_to_page calls
pfn_to_page & page_to_pfn depend on vmemmap being available before the calls if kernel is configured with CONFIG_SPARSEMEM_VMEMMAP=y. This was caused by NOMMU changes which moved vmemmap definition bellow functions definitions calling pfn_to_page & page_to_pfn. Noticed while compiled 5.5-rc2 kernel for Fedora/RISCV. v2: - Add a comment for vmemmap in source Signed-off-by: David Abdurachmanov <[email protected]> Fixes: 6bd33e1 ("riscv: add nommu support") Reviewed-by: Anup Patel <[email protected]> Signed-off-by: Paul Walmsley <[email protected]>
1 parent d411cf0 commit 01f52e1

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

arch/riscv/include/asm/pgtable.h

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,27 @@ extern pgd_t swapper_pg_dir[];
9090
#define __S110 PAGE_SHARED_EXEC
9191
#define __S111 PAGE_SHARED_EXEC
9292

93+
#define VMALLOC_SIZE (KERN_VIRT_SIZE >> 1)
94+
#define VMALLOC_END (PAGE_OFFSET - 1)
95+
#define VMALLOC_START (PAGE_OFFSET - VMALLOC_SIZE)
96+
97+
/*
98+
* Roughly size the vmemmap space to be large enough to fit enough
99+
* struct pages to map half the virtual address space. Then
100+
* position vmemmap directly below the VMALLOC region.
101+
*/
102+
#define VMEMMAP_SHIFT \
103+
(CONFIG_VA_BITS - PAGE_SHIFT - 1 + STRUCT_PAGE_MAX_SHIFT)
104+
#define VMEMMAP_SIZE BIT(VMEMMAP_SHIFT)
105+
#define VMEMMAP_END (VMALLOC_START - 1)
106+
#define VMEMMAP_START (VMALLOC_START - VMEMMAP_SIZE)
107+
108+
/*
109+
* Define vmemmap for pfn_to_page & page_to_pfn calls. Needed if kernel
110+
* is configured with CONFIG_SPARSEMEM_VMEMMAP enabled.
111+
*/
112+
#define vmemmap ((struct page *)VMEMMAP_START)
113+
93114
static inline int pmd_present(pmd_t pmd)
94115
{
95116
return (pmd_val(pmd) & (_PAGE_PRESENT | _PAGE_PROT_NONE));
@@ -400,23 +421,6 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma,
400421
#define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val(pte) })
401422
#define __swp_entry_to_pte(x) ((pte_t) { (x).val })
402423

403-
#define VMALLOC_SIZE (KERN_VIRT_SIZE >> 1)
404-
#define VMALLOC_END (PAGE_OFFSET - 1)
405-
#define VMALLOC_START (PAGE_OFFSET - VMALLOC_SIZE)
406-
407-
/*
408-
* Roughly size the vmemmap space to be large enough to fit enough
409-
* struct pages to map half the virtual address space. Then
410-
* position vmemmap directly below the VMALLOC region.
411-
*/
412-
#define VMEMMAP_SHIFT \
413-
(CONFIG_VA_BITS - PAGE_SHIFT - 1 + STRUCT_PAGE_MAX_SHIFT)
414-
#define VMEMMAP_SIZE BIT(VMEMMAP_SHIFT)
415-
#define VMEMMAP_END (VMALLOC_START - 1)
416-
#define VMEMMAP_START (VMALLOC_START - VMEMMAP_SIZE)
417-
418-
#define vmemmap ((struct page *)VMEMMAP_START)
419-
420424
#define PCI_IO_SIZE SZ_16M
421425
#define PCI_IO_END VMEMMAP_START
422426
#define PCI_IO_START (PCI_IO_END - PCI_IO_SIZE)

0 commit comments

Comments
 (0)