Skip to content

Commit 01f95d4

Browse files
GRobertZiebaTzung-Bi Shih
authored andcommitted
platform/chrome: cros_ec_uart: fix race condition
serdev_device_set_client_ops() is called before `ec_dev` is fully initialized. This can result in cros_ec_uart_rx_bytes() being called while `ec_dev` is still not initialized, resulting in a kernel panic. Call serdev_device_set_client_ops() after `ec_dev` is initialized. Fixes: 04a8bdd ("platform/chrome: cros_ec_uart: Add transport layer") Signed-off-by: Robert Zieba <[email protected]> [tzungbi: modified commit message and fixed context conflict.] Signed-off-by: Tzung-Bi Shih <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent f9bce00 commit 01f95d4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/platform/chrome/cros_ec_uart.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,6 @@ static int cros_ec_uart_probe(struct serdev_device *serdev)
270270
}
271271

272272
serdev_device_set_drvdata(serdev, ec_dev);
273-
serdev_device_set_client_ops(serdev, &cros_ec_uart_client_ops);
274273
init_waitqueue_head(&ec_uart->response.wait_queue);
275274

276275
ec_uart->serdev = serdev;
@@ -300,6 +299,8 @@ static int cros_ec_uart_probe(struct serdev_device *serdev)
300299
sizeof(struct ec_response_get_protocol_info);
301300
ec_dev->dout_size = sizeof(struct ec_host_request);
302301

302+
serdev_device_set_client_ops(serdev, &cros_ec_uart_client_ops);
303+
303304
return cros_ec_register(ec_dev);
304305
}
305306

0 commit comments

Comments
 (0)