Skip to content

Commit 02404ba

Browse files
Steven Rostedtrostedt
authored andcommitted
tracing: Remove deprecated tracing_enabled file
The tracing_enabled file was used as a quick way to stop tracers, and try to bring down overhead for things like the latency tracers (irqsoff, wakeup, etc). But it didn't work that well. The tracing_on file was created as a really fast way to stop recording into the ftrace ring buffer and can interact with the kernel. That is a tracing_off() call in the kernel can disable recording of events, and then from userspace one could echo 1 into the tracing_on file to continue it. The tracing_enabled function did too much to allow for this. The tracing_on has taken over as a way to start and stop tracing and the tracing_enabled file should not be used. But because of its existance, it still confuses people. Over a year ago the following commit was added: commit 6752ab4 Author: Steven Rostedt <[email protected]> Date: Tue Feb 8 13:54:06 2011 -0500 tracing: Deprecate tracing_enabled for tracing_on This commit added a WARN_ON() if the tracing_enabled file's variable was changed. After this was added, only LatencyTop complained, and they soon fixed their tool as there was no reason that LatencyTop should touch this file as it was using the perf ring buffers which this file does not interact with. But since that time no one else has complained about this WARN_ON(). Thus it is safe to assume that this file is no longer needed. Time to get rid of it. Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Signed-off-by: Steven Rostedt <[email protected]>
1 parent 0fb9656 commit 02404ba

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

kernel/trace/trace.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4788,9 +4788,6 @@ static __init int tracer_init_debugfs(void)
47884788

47894789
d_tracer = tracing_init_dentry();
47904790

4791-
trace_create_file("tracing_enabled", 0644, d_tracer,
4792-
&global_trace, &rb_simple_fops);
4793-
47944791
trace_create_file("trace_options", 0644, d_tracer,
47954792
NULL, &tracing_iter_fops);
47964793

0 commit comments

Comments
 (0)