Skip to content

Commit 02d62a8

Browse files
jsmart-ghChristoph Hellwig
authored andcommitted
nvme-fc: release io queues to allow fast fail
Rather than leaving io queues quiesced after tearing down an association, restart them. This allows ios to be replayed, with fastfail ios terminating and non-fastfail getting into loops of retry. This follows rdma's lead. Signed-off-by: James Smart <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent d68a90e commit 02d62a8

File tree

1 file changed

+3
-3
lines changed
  • drivers/nvme/host

1 file changed

+3
-3
lines changed

drivers/nvme/host/fc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2790,6 +2790,9 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
27902790
/* re-enable the admin_q so anything new can fast fail */
27912791
blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
27922792

2793+
/* resume the io queues so that things will fast fail */
2794+
nvme_start_queues(&ctrl->ctrl);
2795+
27932796
nvme_fc_ctlr_inactive_on_rport(ctrl);
27942797
}
27952798

@@ -2804,9 +2807,6 @@ nvme_fc_delete_ctrl(struct nvme_ctrl *nctrl)
28042807
* waiting for io to terminate
28052808
*/
28062809
nvme_fc_delete_association(ctrl);
2807-
2808-
/* resume the io queues so that things will fast fail */
2809-
nvme_start_queues(nctrl);
28102810
}
28112811

28122812
static void

0 commit comments

Comments
 (0)