Skip to content

Commit 02e1dbe

Browse files
davem330davem330
committed
Merge branch 'Pass-extack-to-SWITCHDEV_PORT_OBJ_ADD'
Petr Machata says: ==================== Pass extack to SWITCHDEV_PORT_OBJ_ADD Drivers may need to do validation as a result of port object addition. An example is mlxsw, which needs to check the configuration of a VXLAN device attached to an offloaded bridge. Without a mapped VLAN, the invalidity of the device is not important, but as soon as a pvid, untagged VLAN is configured for the device, it has to be validated and offloaded. Should the validation fail, there's currently no way to communicate details of the failure to the user, beyond an error number. Because currently, extack is not available at all in that area of code, this patch starts down at the RTNL level and progresses up towards the driver(s). In patch #1, ndo_bridge_setlink is updated to include extack, and callbacks of all clients are updated as well (ignoring the argument). In patch #2, the bridge driver is updated to propagate the extack through to the switchdev border, br_switchdev_port_vlan_add(). Patches #3, #4 and #5 then gradually extend switchdev to pass the extack argument through to the switchdev blocking notifier chain. Patches #6 and #7 then update mlxsw to pass the extack argument from VXLAN events resp. port events on to mlxsw_sp_bridge_8021q_vxlan_join(). Finally in patches #8 and #9, the code paths from the previous two patches are verified to yield an error message. v2: - Patch #1: - In ndo_bridge_setlink(), keep the whole extack declaration on the same line. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 351cbde + 06a2fc8 commit 02e1dbe

File tree

19 files changed

+229
-102
lines changed

19 files changed

+229
-102
lines changed

‎drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9618,7 +9618,7 @@ static int bnxt_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
96189618
}
96199619

96209620
static int bnxt_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
9621-
u16 flags)
9621+
u16 flags, struct netlink_ext_ack *extack)
96229622
{
96239623
struct bnxt *bp = netdev_priv(dev);
96249624
struct nlattr *attr, *br_spec;

‎drivers/net/ethernet/emulex/benet/be_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4955,7 +4955,7 @@ int be_load_fw(struct be_adapter *adapter, u8 *fw_file)
49554955
}
49564956

49574957
static int be_ndo_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
4958-
u16 flags)
4958+
u16 flags, struct netlink_ext_ack *extack)
49594959
{
49604960
struct be_adapter *adapter = netdev_priv(dev);
49614961
struct nlattr *attr, *br_spec;

‎drivers/net/ethernet/intel/i40e/i40e_main.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11685,6 +11685,7 @@ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
1168511685
* @dev: the netdev being configured
1168611686
* @nlh: RTNL message
1168711687
* @flags: bridge flags
11688+
* @extack: netlink extended ack
1168811689
*
1168911690
* Inserts a new hardware bridge if not already created and
1169011691
* enables the bridging mode requested (VEB or VEPA). If the
@@ -11697,7 +11698,8 @@ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
1169711698
**/
1169811699
static int i40e_ndo_bridge_setlink(struct net_device *dev,
1169911700
struct nlmsghdr *nlh,
11700-
u16 flags)
11701+
u16 flags,
11702+
struct netlink_ext_ack *extack)
1170111703
{
1170211704
struct i40e_netdev_priv *np = netdev_priv(dev);
1170311705
struct i40e_vsi *vsi = np->vsi;

‎drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3624,6 +3624,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode)
36243624
* @dev: the netdev being configured
36253625
* @nlh: RTNL message
36263626
* @flags: bridge setlink flags
3627+
* @extack: netlink extended ack
36273628
*
36283629
* Sets the bridge mode (VEB/VEPA) of the switch to which the netdev (VSI) is
36293630
* hooked up to. Iterates through the PF VSI list and sets the loopback mode (if
@@ -3632,7 +3633,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode)
36323633
*/
36333634
static int
36343635
ice_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
3635-
u16 __always_unused flags)
3636+
u16 __always_unused flags, struct netlink_ext_ack *extack)
36363637
{
36373638
struct ice_netdev_priv *np = netdev_priv(dev);
36383639
struct ice_pf *pf = np->vsi->back;

‎drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9979,7 +9979,8 @@ static int ixgbe_configure_bridge_mode(struct ixgbe_adapter *adapter,
99799979
}
99809980

99819981
static int ixgbe_ndo_bridge_setlink(struct net_device *dev,
9982-
struct nlmsghdr *nlh, u16 flags)
9982+
struct nlmsghdr *nlh, u16 flags,
9983+
struct netlink_ext_ack *extack)
99839984
{
99849985
struct ixgbe_adapter *adapter = netdev_priv(dev);
99859986
struct nlattr *attr, *br_spec;

‎drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c

Lines changed: 33 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ struct mlxsw_sp_bridge_ops {
8989
struct netlink_ext_ack *extack);
9090
struct mlxsw_sp_fid *
9191
(*fid_get)(struct mlxsw_sp_bridge_device *bridge_device,
92-
u16 vid);
92+
u16 vid, struct netlink_ext_ack *extack);
9393
struct mlxsw_sp_fid *
9494
(*fid_lookup)(struct mlxsw_sp_bridge_device *bridge_device,
9595
u16 vid);
@@ -933,7 +933,8 @@ static int mlxsw_sp_port_attr_set(struct net_device *dev,
933933

934934
static int
935935
mlxsw_sp_port_vlan_fid_join(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan,
936-
struct mlxsw_sp_bridge_port *bridge_port)
936+
struct mlxsw_sp_bridge_port *bridge_port,
937+
struct netlink_ext_ack *extack)
937938
{
938939
struct mlxsw_sp_port *mlxsw_sp_port = mlxsw_sp_port_vlan->mlxsw_sp_port;
939940
struct mlxsw_sp_bridge_device *bridge_device;
@@ -943,7 +944,7 @@ mlxsw_sp_port_vlan_fid_join(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan,
943944
int err;
944945

945946
bridge_device = bridge_port->bridge_device;
946-
fid = bridge_device->ops->fid_get(bridge_device, vid);
947+
fid = bridge_device->ops->fid_get(bridge_device, vid, extack);
947948
if (IS_ERR(fid))
948949
return PTR_ERR(fid);
949950

@@ -1011,7 +1012,8 @@ mlxsw_sp_port_pvid_determine(const struct mlxsw_sp_port *mlxsw_sp_port,
10111012

10121013
static int
10131014
mlxsw_sp_port_vlan_bridge_join(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan,
1014-
struct mlxsw_sp_bridge_port *bridge_port)
1015+
struct mlxsw_sp_bridge_port *bridge_port,
1016+
struct netlink_ext_ack *extack)
10151017
{
10161018
struct mlxsw_sp_port *mlxsw_sp_port = mlxsw_sp_port_vlan->mlxsw_sp_port;
10171019
struct mlxsw_sp_bridge_vlan *bridge_vlan;
@@ -1024,7 +1026,8 @@ mlxsw_sp_port_vlan_bridge_join(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan,
10241026
return 0;
10251027
}
10261028

1027-
err = mlxsw_sp_port_vlan_fid_join(mlxsw_sp_port_vlan, bridge_port);
1029+
err = mlxsw_sp_port_vlan_fid_join(mlxsw_sp_port_vlan, bridge_port,
1030+
extack);
10281031
if (err)
10291032
return err;
10301033

@@ -1101,7 +1104,8 @@ mlxsw_sp_port_vlan_bridge_leave(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan)
11011104
static int
11021105
mlxsw_sp_bridge_port_vlan_add(struct mlxsw_sp_port *mlxsw_sp_port,
11031106
struct mlxsw_sp_bridge_port *bridge_port,
1104-
u16 vid, bool is_untagged, bool is_pvid)
1107+
u16 vid, bool is_untagged, bool is_pvid,
1108+
struct netlink_ext_ack *extack)
11051109
{
11061110
u16 pvid = mlxsw_sp_port_pvid_determine(mlxsw_sp_port, vid, is_pvid);
11071111
struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan;
@@ -1121,7 +1125,8 @@ mlxsw_sp_bridge_port_vlan_add(struct mlxsw_sp_port *mlxsw_sp_port,
11211125
if (err)
11221126
goto err_port_pvid_set;
11231127

1124-
err = mlxsw_sp_port_vlan_bridge_join(mlxsw_sp_port_vlan, bridge_port);
1128+
err = mlxsw_sp_port_vlan_bridge_join(mlxsw_sp_port_vlan, bridge_port,
1129+
extack);
11251130
if (err)
11261131
goto err_port_vlan_bridge_join;
11271132

@@ -1171,7 +1176,8 @@ mlxsw_sp_br_ban_rif_pvid_change(struct mlxsw_sp *mlxsw_sp,
11711176

11721177
static int mlxsw_sp_port_vlans_add(struct mlxsw_sp_port *mlxsw_sp_port,
11731178
const struct switchdev_obj_port_vlan *vlan,
1174-
struct switchdev_trans *trans)
1179+
struct switchdev_trans *trans,
1180+
struct netlink_ext_ack *extack)
11751181
{
11761182
bool flag_untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
11771183
bool flag_pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
@@ -1208,7 +1214,7 @@ static int mlxsw_sp_port_vlans_add(struct mlxsw_sp_port *mlxsw_sp_port,
12081214

12091215
err = mlxsw_sp_bridge_port_vlan_add(mlxsw_sp_port, bridge_port,
12101216
vid, flag_untagged,
1211-
flag_pvid);
1217+
flag_pvid, extack);
12121218
if (err)
12131219
return err;
12141220
}
@@ -1777,7 +1783,8 @@ static void mlxsw_sp_span_respin_schedule(struct mlxsw_sp *mlxsw_sp)
17771783

17781784
static int mlxsw_sp_port_obj_add(struct net_device *dev,
17791785
const struct switchdev_obj *obj,
1780-
struct switchdev_trans *trans)
1786+
struct switchdev_trans *trans,
1787+
struct netlink_ext_ack *extack)
17811788
{
17821789
struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev);
17831790
const struct switchdev_obj_port_vlan *vlan;
@@ -1786,7 +1793,8 @@ static int mlxsw_sp_port_obj_add(struct net_device *dev,
17861793
switch (obj->id) {
17871794
case SWITCHDEV_OBJ_ID_PORT_VLAN:
17881795
vlan = SWITCHDEV_OBJ_PORT_VLAN(obj);
1789-
err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, trans);
1796+
err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, trans,
1797+
extack);
17901798

17911799
if (switchdev_trans_ph_prepare(trans)) {
17921800
/* The event is emitted before the changes are actually
@@ -2086,7 +2094,7 @@ mlxsw_sp_bridge_8021q_vxlan_dev_find(struct net_device *br_dev, u16 vid)
20862094

20872095
static struct mlxsw_sp_fid *
20882096
mlxsw_sp_bridge_8021q_fid_get(struct mlxsw_sp_bridge_device *bridge_device,
2089-
u16 vid)
2097+
u16 vid, struct netlink_ext_ack *extack)
20902098
{
20912099
struct mlxsw_sp *mlxsw_sp = mlxsw_sp_lower_get(bridge_device->dev);
20922100
struct net_device *vxlan_dev;
@@ -2112,7 +2120,7 @@ mlxsw_sp_bridge_8021q_fid_get(struct mlxsw_sp_bridge_device *bridge_device,
21122120
return fid;
21132121

21142122
err = mlxsw_sp_bridge_8021q_vxlan_join(bridge_device, vxlan_dev, vid,
2115-
NULL);
2123+
extack);
21162124
if (err)
21172125
goto err_vxlan_join;
21182126

@@ -2189,7 +2197,8 @@ mlxsw_sp_bridge_8021d_port_join(struct mlxsw_sp_bridge_device *bridge_device,
21892197
if (mlxsw_sp_port_vlan->fid)
21902198
mlxsw_sp_port_vlan_router_leave(mlxsw_sp_port_vlan);
21912199

2192-
return mlxsw_sp_port_vlan_bridge_join(mlxsw_sp_port_vlan, bridge_port);
2200+
return mlxsw_sp_port_vlan_bridge_join(mlxsw_sp_port_vlan, bridge_port,
2201+
extack);
21932202
}
21942203

21952204
static void
@@ -2252,7 +2261,7 @@ mlxsw_sp_bridge_8021d_vxlan_join(struct mlxsw_sp_bridge_device *bridge_device,
22522261

22532262
static struct mlxsw_sp_fid *
22542263
mlxsw_sp_bridge_8021d_fid_get(struct mlxsw_sp_bridge_device *bridge_device,
2255-
u16 vid)
2264+
u16 vid, struct netlink_ext_ack *extack)
22562265
{
22572266
struct mlxsw_sp *mlxsw_sp = mlxsw_sp_lower_get(bridge_device->dev);
22582267
struct net_device *vxlan_dev;
@@ -2274,7 +2283,7 @@ mlxsw_sp_bridge_8021d_fid_get(struct mlxsw_sp_bridge_device *bridge_device,
22742283
return fid;
22752284

22762285
err = mlxsw_sp_bridge_8021d_vxlan_join(bridge_device, vxlan_dev, 0,
2277-
NULL);
2286+
extack);
22782287
if (err)
22792288
goto err_vxlan_join;
22802289

@@ -3204,7 +3213,8 @@ mlxsw_sp_switchdev_vxlan_vlan_add(struct mlxsw_sp *mlxsw_sp,
32043213
struct mlxsw_sp_bridge_device *bridge_device,
32053214
const struct net_device *vxlan_dev, u16 vid,
32063215
bool flag_untagged, bool flag_pvid,
3207-
struct switchdev_trans *trans)
3216+
struct switchdev_trans *trans,
3217+
struct netlink_ext_ack *extack)
32083218
{
32093219
struct vxlan_dev *vxlan = netdev_priv(vxlan_dev);
32103220
__be32 vni = vxlan->cfg.vni;
@@ -3236,7 +3246,7 @@ mlxsw_sp_switchdev_vxlan_vlan_add(struct mlxsw_sp *mlxsw_sp,
32363246
if (!flag_untagged || !flag_pvid)
32373247
return 0;
32383248
return mlxsw_sp_bridge_8021q_vxlan_join(bridge_device,
3239-
vxlan_dev, vid, NULL);
3249+
vxlan_dev, vid, extack);
32403250
}
32413251

32423252
/* Second case: FID is associated with the VNI and the VLAN associated
@@ -3276,7 +3286,7 @@ mlxsw_sp_switchdev_vxlan_vlan_add(struct mlxsw_sp *mlxsw_sp,
32763286
return 0;
32773287

32783288
err = mlxsw_sp_bridge_8021q_vxlan_join(bridge_device, vxlan_dev, vid,
3279-
NULL);
3289+
extack);
32803290
if (err)
32813291
goto err_vxlan_join;
32823292

@@ -3325,10 +3335,12 @@ mlxsw_sp_switchdev_vxlan_vlans_add(struct net_device *vxlan_dev,
33253335
bool flag_pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
33263336
struct switchdev_trans *trans = port_obj_info->trans;
33273337
struct mlxsw_sp_bridge_device *bridge_device;
3338+
struct netlink_ext_ack *extack;
33283339
struct mlxsw_sp *mlxsw_sp;
33293340
struct net_device *br_dev;
33303341
u16 vid;
33313342

3343+
extack = switchdev_notifier_info_to_extack(&port_obj_info->info);
33323344
br_dev = netdev_master_upper_dev_get(vxlan_dev);
33333345
if (!br_dev)
33343346
return 0;
@@ -3352,7 +3364,8 @@ mlxsw_sp_switchdev_vxlan_vlans_add(struct net_device *vxlan_dev,
33523364
err = mlxsw_sp_switchdev_vxlan_vlan_add(mlxsw_sp, bridge_device,
33533365
vxlan_dev, vid,
33543366
flag_untagged,
3355-
flag_pvid, trans);
3367+
flag_pvid, trans,
3368+
extack);
33563369
if (err)
33573370
return err;
33583371
}

‎drivers/net/ethernet/mscc/ocelot.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1293,7 +1293,8 @@ static int ocelot_port_obj_del_mdb(struct net_device *dev,
12931293

12941294
static int ocelot_port_obj_add(struct net_device *dev,
12951295
const struct switchdev_obj *obj,
1296-
struct switchdev_trans *trans)
1296+
struct switchdev_trans *trans,
1297+
struct netlink_ext_ack *extack)
12971298
{
12981299
int ret = 0;
12991300

‎drivers/net/vxlan.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ static void vxlan_fdb_switchdev_notifier_info(const struct vxlan_dev *vxlan,
364364
struct switchdev_notifier_vxlan_fdb_info *fdb_info)
365365
{
366366
fdb_info->info.dev = vxlan->dev;
367+
fdb_info->info.extack = NULL;
367368
fdb_info->remote_ip = rd->remote_ip;
368369
fdb_info->remote_port = rd->remote_port;
369370
fdb_info->remote_vni = rd->remote_vni;

‎include/linux/netdevice.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,7 @@ struct dev_ifalias {
11651165
* entries to skb and update idx with the number of entries.
11661166
*
11671167
* int (*ndo_bridge_setlink)(struct net_device *dev, struct nlmsghdr *nlh,
1168-
* u16 flags)
1168+
* u16 flags, struct netlink_ext_ack *extack)
11691169
* int (*ndo_bridge_getlink)(struct sk_buff *skb, u32 pid, u32 seq,
11701170
* struct net_device *dev, u32 filter_mask,
11711171
* int nlflags)
@@ -1390,7 +1390,8 @@ struct net_device_ops {
13901390

13911391
int (*ndo_bridge_setlink)(struct net_device *dev,
13921392
struct nlmsghdr *nlh,
1393-
u16 flags);
1393+
u16 flags,
1394+
struct netlink_ext_ack *extack);
13941395
int (*ndo_bridge_getlink)(struct sk_buff *skb,
13951396
u32 pid, u32 seq,
13961397
struct net_device *dev,

‎include/net/switchdev.h

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ enum switchdev_notifier_type {
149149

150150
struct switchdev_notifier_info {
151151
struct net_device *dev;
152+
struct netlink_ext_ack *extack;
152153
};
153154

154155
struct switchdev_notifier_fdb_info {
@@ -172,6 +173,12 @@ switchdev_notifier_info_to_dev(const struct switchdev_notifier_info *info)
172173
return info->dev;
173174
}
174175

176+
static inline struct netlink_ext_ack *
177+
switchdev_notifier_info_to_extack(const struct switchdev_notifier_info *info)
178+
{
179+
return info->extack;
180+
}
181+
175182
#ifdef CONFIG_NET_SWITCHDEV
176183

177184
void switchdev_deferred_process(void);
@@ -180,7 +187,8 @@ int switchdev_port_attr_get(struct net_device *dev,
180187
int switchdev_port_attr_set(struct net_device *dev,
181188
const struct switchdev_attr *attr);
182189
int switchdev_port_obj_add(struct net_device *dev,
183-
const struct switchdev_obj *obj);
190+
const struct switchdev_obj *obj,
191+
struct netlink_ext_ack *extack);
184192
int switchdev_port_obj_del(struct net_device *dev,
185193
const struct switchdev_obj *obj);
186194

@@ -192,7 +200,8 @@ int call_switchdev_notifiers(unsigned long val, struct net_device *dev,
192200
int register_switchdev_blocking_notifier(struct notifier_block *nb);
193201
int unregister_switchdev_blocking_notifier(struct notifier_block *nb);
194202
int call_switchdev_blocking_notifiers(unsigned long val, struct net_device *dev,
195-
struct switchdev_notifier_info *info);
203+
struct switchdev_notifier_info *info,
204+
struct netlink_ext_ack *extack);
196205

197206
void switchdev_port_fwd_mark_set(struct net_device *dev,
198207
struct net_device *group_dev,
@@ -206,7 +215,8 @@ int switchdev_handle_port_obj_add(struct net_device *dev,
206215
bool (*check_cb)(const struct net_device *dev),
207216
int (*add_cb)(struct net_device *dev,
208217
const struct switchdev_obj *obj,
209-
struct switchdev_trans *trans));
218+
struct switchdev_trans *trans,
219+
struct netlink_ext_ack *extack));
210220
int switchdev_handle_port_obj_del(struct net_device *dev,
211221
struct switchdev_notifier_port_obj_info *port_obj_info,
212222
bool (*check_cb)(const struct net_device *dev),
@@ -233,7 +243,8 @@ static inline int switchdev_port_attr_set(struct net_device *dev,
233243
}
234244

235245
static inline int switchdev_port_obj_add(struct net_device *dev,
236-
const struct switchdev_obj *obj)
246+
const struct switchdev_obj *obj,
247+
struct netlink_ext_ack *extack)
237248
{
238249
return -EOPNOTSUPP;
239250
}
@@ -276,7 +287,8 @@ unregister_switchdev_blocking_notifier(struct notifier_block *nb)
276287
static inline int
277288
call_switchdev_blocking_notifiers(unsigned long val,
278289
struct net_device *dev,
279-
struct switchdev_notifier_info *info)
290+
struct switchdev_notifier_info *info,
291+
struct netlink_ext_ack *extack)
280292
{
281293
return NOTIFY_DONE;
282294
}
@@ -293,7 +305,8 @@ switchdev_handle_port_obj_add(struct net_device *dev,
293305
bool (*check_cb)(const struct net_device *dev),
294306
int (*add_cb)(struct net_device *dev,
295307
const struct switchdev_obj *obj,
296-
struct switchdev_trans *trans))
308+
struct switchdev_trans *trans,
309+
struct netlink_ext_ack *extack))
297310
{
298311
return 0;
299312
}

‎net/bridge/br_if.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev,
650650
if (br_fdb_insert(br, p, dev->dev_addr, 0))
651651
netdev_err(dev, "failed insert local address bridge forwarding table\n");
652652

653-
err = nbp_vlan_init(p);
653+
err = nbp_vlan_init(p, extack);
654654
if (err) {
655655
netdev_err(dev, "failed to initialize vlan filtering on this port\n");
656656
goto err7;

0 commit comments

Comments
 (0)