media: c8sectpfe: Call of_node_put(i2c_bus) only once in c8sectpfe_probe()

elfring · jfvogel · commit 02f1784ab21a · 2025-06-02T22:34:13.000-07:00
[ Upstream commit b773530a34df0687020520015057075f8b7b4ac4 ]

An of_node_put(i2c_bus) call was immediately used after a pointer check
for an of_find_i2c_adapter_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Signed-off-by: Hans Verkuil &lt;hverkuil@xs4all.nl&gt;
Signed-off-by: Sasha Levin &lt;sashal@kernel.org&gt;
(cherry picked from commit 5520fed18df866d7821fbde9549c6cb7beb096ee)
Signed-off-by: Jack Vogel &lt;jack.vogel@oracle.com&gt;
diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
@@ -797,13 +797,12 @@ static int c8sectpfe_probe(struct platform_device *pdev)
 		}
 		tsin->i2c_adapter =
 			of_find_i2c_adapter_by_node(i2c_bus);
+		of_node_put(i2c_bus);
 		if (!tsin->i2c_adapter) {
 			dev_err(&pdev->dev, "No i2c adapter found\n");
-			of_node_put(i2c_bus);
 			ret = -ENODEV;
 			goto err_node_put;
 		}
-		of_node_put(i2c_bus);
 
 		/* Acquire reset GPIO and activate it */
 		tsin->rst_gpio = devm_fwnode_gpiod_get(dev,

Original file line number	Diff line number	Diff line change
`@@ -797,13 +797,12 @@ static int c8sectpfe_probe(struct platform_device *pdev)`
`797`	`797`	`}`
`798`	`798`	`tsin->i2c_adapter =`
`799`	`799`	`of_find_i2c_adapter_by_node(i2c_bus);`
	`800`	`+ of_node_put(i2c_bus);`
`800`	`801`	`if (!tsin->i2c_adapter) {`
`801`	`802`	`dev_err(&pdev->dev, "No i2c adapter found\n");`
`802`		`- of_node_put(i2c_bus);`
`803`	`803`	`ret = -ENODEV;`
`804`	`804`	`goto err_node_put;`
`805`	`805`	`}`
`806`		`- of_node_put(i2c_bus);`
`807`	`806`
`808`	`807`	`/* Acquire reset GPIO and activate it */`
`809`	`808`	`tsin->rst_gpio = devm_fwnode_gpiod_get(dev,`