Skip to content

Commit 0317c6c

Browse files
Dan Carpenterairlied
authored andcommitted
drm/i915/bios: cleanup return type of intel_parse_bios()
These are unintuitive. These are type bool and return -1 casted to true on failure. Let's just make it return an int. The callers don't care, but let's change this as a cleanup. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Daniel Vetter <[email protected]> Signed-off-by: Dave Airlie <[email protected]>
1 parent 7c01433 commit 0317c6c

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

drivers/gpu/drm/gma500/intel_bios.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ parse_device_mapping(struct drm_psb_private *dev_priv,
427427
*
428428
* Returns 0 on success, nonzero on failure.
429429
*/
430-
bool psb_intel_init_bios(struct drm_device *dev)
430+
int psb_intel_init_bios(struct drm_device *dev)
431431
{
432432
struct drm_psb_private *dev_priv = dev->dev_private;
433433
struct pci_dev *pdev = dev->pdev;

drivers/gpu/drm/gma500/intel_bios.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ struct bdb_driver_features {
431431
u8 custom_vbt_version;
432432
} __attribute__((packed));
433433

434-
extern bool psb_intel_init_bios(struct drm_device *dev);
434+
extern int psb_intel_init_bios(struct drm_device *dev);
435435
extern void psb_intel_destroy_bios(struct drm_device *dev);
436436

437437
/*

drivers/gpu/drm/i915/intel_bios.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ static const struct dmi_system_id intel_no_opregion_vbt[] = {
692692
*
693693
* Returns 0 on success, nonzero on failure.
694694
*/
695-
bool
695+
int
696696
intel_parse_bios(struct drm_device *dev)
697697
{
698698
struct drm_i915_private *dev_priv = dev->dev_private;

drivers/gpu/drm/i915/intel_bios.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ struct bdb_edp {
476476
} __attribute__ ((packed));
477477

478478
void intel_setup_bios(struct drm_device *dev);
479-
bool intel_parse_bios(struct drm_device *dev);
479+
int intel_parse_bios(struct drm_device *dev);
480480

481481
/*
482482
* Driver<->VBIOS interaction occurs through scratch bits in

0 commit comments

Comments
 (0)