Skip to content

Commit 0362fcc

Browse files
shawn1221mmind
authored andcommitted
arm64: dts: rockchip: remove always-on and boot-on from vcc_sd
Please don't add these for vcc_sd, and mmc-core/driver will control it. Otherwise, it will waste energy even without sdmmc in slot. Moreover, it will causes a bug: If we insert/remove sd card, we could see [9.337271] mmc0: new ultra high speed SDR25 SDHC card at address 0007 [9.345144] mmcblk0: mmc0:0007 SD32G 29.3 GiB This is okay for normal sd insert/remove test, but when I debug some issues for sdmmc, I did unbind/bind test. And there is a interesting phenomenon when we bind the driver again: [58.314069] mmc0: new high speed SDHC card at address 0007 [58.320282] mmcblk0: mmc0:0007 SD32G 29.3 GiB So the sd card could just support high speed without power cycle since the vcc_sd is always on, which makes the sd card fail to reinit its internal ocr mask. Signed-off-by: Shawn Lin <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 1001354 commit 0362fcc

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,6 @@
258258
};
259259

260260
vcc_sd: SWITCH_REG1 {
261-
regulator-always-on;
262-
regulator-boot-on;
263261
regulator-name = "vcc_sd";
264262
};
265263

arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,6 @@
152152
gpio = <&gpio3 11 GPIO_ACTIVE_LOW>;
153153
regulator-min-microvolt = <1800000>;
154154
regulator-max-microvolt = <3300000>;
155-
regulator-always-on;
156-
regulator-boot-on;
157155
vin-supply = <&vcc_io>;
158156
};
159157

0 commit comments

Comments
 (0)