Skip to content

Commit 036e7aa

Browse files
Matthew Wilcoxtorvalds
authored andcommitted
mm: store compound_dtor / compound_order as bytes
Neither of these values get even close to 256; compound_dtor is currently at a maximum of 3, and compound_order can't be over 64. No machine has inefficient access to bytes since EV5, and while those are still supported, we don't optimise for them any more. This does not shrink struct page, but it removes an ifdef and frees up 2-6 bytes for future use. diff of pahole output: struct callback_head callback_head; /* 32 16 */ struct { long unsigned int compound_head; /* 32 8 */ - unsigned int compound_dtor; /* 40 4 */ - unsigned int compound_order; /* 44 4 */ + unsigned char compound_dtor; /* 40 1 */ + unsigned char compound_order; /* 41 1 */ }; /* 32 16 */ }; /* 32 16 */ union { [[email protected]: add comment] Link: http://lkml.kernel.org/r/[email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Matthew Wilcox <[email protected]> Acked-by: Kirill A. Shutemov <[email protected]> Acked-by: Michal Hocko <[email protected]> Cc: Christoph Lameter <[email protected]> Cc: Randy Dunlap <[email protected]> Signed-off-by: Matthew Wilcox <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 0dd4da5 commit 036e7aa

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

include/linux/mm_types.h

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -136,19 +136,9 @@ struct page {
136136
unsigned long compound_head; /* If bit zero is set */
137137

138138
/* First tail page only */
139-
#ifdef CONFIG_64BIT
140-
/*
141-
* On 64 bit system we have enough space in struct page
142-
* to encode compound_dtor and compound_order with
143-
* unsigned int. It can help compiler generate better or
144-
* smaller code on some archtectures.
145-
*/
146-
unsigned int compound_dtor;
147-
unsigned int compound_order;
148-
#else
149-
unsigned short int compound_dtor;
150-
unsigned short int compound_order;
151-
#endif
139+
unsigned char compound_dtor;
140+
unsigned char compound_order;
141+
/* two/six bytes available here */
152142
};
153143

154144
#if defined(CONFIG_TRANSPARENT_HUGEPAGE) && USE_SPLIT_PMD_PTLOCKS

0 commit comments

Comments
 (0)