Skip to content

Commit 04462f2

Browse files
Philippe Reynesdavem330
authored andcommitted
net: ethernet: renesas: ravb: use new api ethtool_{get|set}_link_ksettings
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes <[email protected]> Acked-by: Sergei Shtylyov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0f63517 commit 04462f2

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,22 +1049,24 @@ static int ravb_phy_start(struct net_device *ndev)
10491049
return 0;
10501050
}
10511051

1052-
static int ravb_get_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
1052+
static int ravb_get_link_ksettings(struct net_device *ndev,
1053+
struct ethtool_link_ksettings *cmd)
10531054
{
10541055
struct ravb_private *priv = netdev_priv(ndev);
10551056
int error = -ENODEV;
10561057
unsigned long flags;
10571058

10581059
if (ndev->phydev) {
10591060
spin_lock_irqsave(&priv->lock, flags);
1060-
error = phy_ethtool_gset(ndev->phydev, ecmd);
1061+
error = phy_ethtool_ksettings_get(ndev->phydev, cmd);
10611062
spin_unlock_irqrestore(&priv->lock, flags);
10621063
}
10631064

10641065
return error;
10651066
}
10661067

1067-
static int ravb_set_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
1068+
static int ravb_set_link_ksettings(struct net_device *ndev,
1069+
const struct ethtool_link_ksettings *cmd)
10681070
{
10691071
struct ravb_private *priv = netdev_priv(ndev);
10701072
unsigned long flags;
@@ -1078,11 +1080,11 @@ static int ravb_set_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
10781080
/* Disable TX and RX */
10791081
ravb_rcv_snd_disable(ndev);
10801082

1081-
error = phy_ethtool_sset(ndev->phydev, ecmd);
1083+
error = phy_ethtool_ksettings_set(ndev->phydev, cmd);
10821084
if (error)
10831085
goto error_exit;
10841086

1085-
if (ecmd->duplex == DUPLEX_FULL)
1087+
if (cmd->base.duplex == DUPLEX_FULL)
10861088
priv->duplex = 1;
10871089
else
10881090
priv->duplex = 0;
@@ -1306,8 +1308,6 @@ static int ravb_get_ts_info(struct net_device *ndev,
13061308
}
13071309

13081310
static const struct ethtool_ops ravb_ethtool_ops = {
1309-
.get_settings = ravb_get_settings,
1310-
.set_settings = ravb_set_settings,
13111311
.nway_reset = ravb_nway_reset,
13121312
.get_msglevel = ravb_get_msglevel,
13131313
.set_msglevel = ravb_set_msglevel,
@@ -1318,6 +1318,8 @@ static const struct ethtool_ops ravb_ethtool_ops = {
13181318
.get_ringparam = ravb_get_ringparam,
13191319
.set_ringparam = ravb_set_ringparam,
13201320
.get_ts_info = ravb_get_ts_info,
1321+
.get_link_ksettings = ravb_get_link_ksettings,
1322+
.set_link_ksettings = ravb_set_link_ksettings,
13211323
};
13221324

13231325
static inline int ravb_hook_irq(unsigned int irq, irq_handler_t handler,

0 commit comments

Comments
 (0)