Skip to content

Commit 04b28f4

Browse files
Dan Carpentergregkh
authored andcommitted
ipv4: frags: precedence bug in ip_expire()
We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527 ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: David S. Miller <[email protected]> (cherry picked from commit 70837ff) Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6b92153 commit 04b28f4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/ipv4/ip_fragment.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ static void ip_expire(struct timer_list *t)
154154
__IP_INC_STATS(net, IPSTATS_MIB_REASMFAILS);
155155
__IP_INC_STATS(net, IPSTATS_MIB_REASMTIMEOUT);
156156

157-
if (!qp->q.flags & INET_FRAG_FIRST_IN)
157+
if (!(qp->q.flags & INET_FRAG_FIRST_IN))
158158
goto out;
159159

160160
/* sk_buff::dev and sk_buff::rbnode are unionized. So we

0 commit comments

Comments
 (0)