Skip to content

Commit 04ddc2a

Browse files
Chaya Rachel Ivgiegrumbach
authored andcommitted
iwlwifi: mvm: fix unregistration of thermal in some error flows
The call to iwl_mvm_thermal_initialize() was too early in the function. Unregister will be performed when goto out_unregister is called, but as the code was - out_free may be called and leave without unregistering from thermal. Signed-off-by: Chaya Rachel Ivgi <[email protected]> Signed-off-by: Emmanuel Grumbach <[email protected]>
1 parent afd5b17 commit 04ddc2a

File tree

1 file changed

+3
-3
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+3
-3
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/ops.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -611,9 +611,6 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg,
611611
IWL_INFO(mvm, "Detected %s, REV=0x%X\n",
612612
mvm->cfg->name, mvm->trans->hw_rev);
613613

614-
min_backoff = calc_min_backoff(trans, cfg);
615-
iwl_mvm_thermal_initialize(mvm, min_backoff);
616-
617614
if (iwlwifi_mod_params.nvm_file)
618615
mvm->nvm_file_name = iwlwifi_mod_params.nvm_file;
619616
else
@@ -666,6 +663,9 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg,
666663
if (err)
667664
goto out_free;
668665

666+
min_backoff = calc_min_backoff(trans, cfg);
667+
iwl_mvm_thermal_initialize(mvm, min_backoff);
668+
669669
err = iwl_mvm_dbgfs_register(mvm, dbgfs_dir);
670670
if (err)
671671
goto out_unregister;

0 commit comments

Comments
 (0)