Skip to content

Commit 0510d81

Browse files
Alphixmchehab
authored andcommitted
[media] media: lirc_dev: use cdev_device_add() helper function
Replace calls to cdev_add() and device_add() with the cdev_device_add() helper function. Signed-off-by: David Härdeman <[email protected]> Signed-off-by: Sean Young <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent c3c6dd7 commit 0510d81

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

drivers/media/rc/lirc_dev.c

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -193,17 +193,11 @@ int lirc_register_driver(struct lirc_driver *d)
193193

194194
cdev_init(&ir->cdev, d->fops);
195195
ir->cdev.owner = ir->d.owner;
196-
ir->cdev.kobj.parent = &ir->dev.kobj;
197-
198-
err = cdev_add(&ir->cdev, ir->dev.devt, 1);
199-
if (err)
200-
goto out_free_dev;
201-
202196
ir->attached = 1;
203197

204-
err = device_add(&ir->dev);
198+
err = cdev_device_add(&ir->cdev, &ir->dev);
205199
if (err)
206-
goto out_cdev;
200+
goto out_dev;
207201

208202
mutex_unlock(&lirc_dev_lock);
209203

@@ -214,9 +208,7 @@ int lirc_register_driver(struct lirc_driver *d)
214208

215209
return 0;
216210

217-
out_cdev:
218-
cdev_del(&ir->cdev);
219-
out_free_dev:
211+
out_dev:
220212
put_device(&ir->dev);
221213
out_lock:
222214
mutex_unlock(&lirc_dev_lock);
@@ -248,8 +240,7 @@ void lirc_unregister_driver(struct lirc_driver *d)
248240

249241
mutex_unlock(&lirc_dev_lock);
250242

251-
device_del(&ir->dev);
252-
cdev_del(&ir->cdev);
243+
cdev_device_del(&ir->cdev, &ir->dev);
253244
put_device(&ir->dev);
254245
}
255246
EXPORT_SYMBOL(lirc_unregister_driver);

0 commit comments

Comments
 (0)