Skip to content

Commit 059bc9f

Browse files
committed
kbuild: make 'archprepare' depend on 'scripts'
Before start descending, Kbuild needs to run 'prepare' and 'scripts', which has been orthogonal to each other. Going forward, let's consider 'scripts' is a part of the preparation. This will allow more cleanups. Move 'scripts' to the prerequisite of 'archprepare', where UML starts compiling target *.c files. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 60df1ae commit 059bc9f

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

Makefile

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ $(sort $(vmlinux-deps)): $(vmlinux-dirs) ;
10601060
# Error messages still appears in the original language
10611061

10621062
PHONY += $(vmlinux-dirs)
1063-
$(vmlinux-dirs): prepare scripts
1063+
$(vmlinux-dirs): prepare
10641064
$(Q)$(MAKE) $(build)=$@ need-builtin=1
10651065

10661066
define filechk_kernel.release
@@ -1110,7 +1110,7 @@ prepare1: prepare2 $(version_h) $(autoksyms_h) include/generated/utsrelease.h
11101110

11111111
macroprepare: prepare1 archmacros
11121112

1113-
archprepare: archheaders archscripts macroprepare scripts_basic gcc-plugins
1113+
archprepare: archheaders archscripts macroprepare scripts gcc-plugins
11141114

11151115
prepare0: archprepare
11161116
$(Q)$(MAKE) $(build)=scripts/mod
@@ -1284,7 +1284,7 @@ modules.builtin: $(vmlinux-dirs:%=%/modules.builtin)
12841284

12851285
# Target to prepare building external modules
12861286
PHONY += modules_prepare
1287-
modules_prepare: prepare scripts
1287+
modules_prepare: prepare
12881288

12891289
# Target to install modules
12901290
PHONY += modules_install
@@ -1602,11 +1602,9 @@ help:
16021602
@echo ' clean - remove generated files in module directory only'
16031603
@echo ''
16041604

1605-
# Dummies...
1606-
PHONY += prepare scripts
1605+
PHONY += prepare
16071606
prepare:
16081607
$(cmd_crmodverdir)
1609-
scripts: ;
16101608
endif # KBUILD_EXTMOD
16111609

16121610
clean: $(clean-dirs)
@@ -1710,33 +1708,33 @@ else
17101708
target-dir = $(if $(KBUILD_EXTMOD),$(dir $<),$(dir $@))
17111709
endif
17121710

1713-
%.s: %.c prepare scripts FORCE
1711+
%.s: %.c prepare FORCE
17141712
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1715-
%.i: %.c prepare scripts FORCE
1713+
%.i: %.c prepare FORCE
17161714
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1717-
%.o: %.c prepare scripts FORCE
1715+
%.o: %.c prepare FORCE
17181716
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1719-
%.lst: %.c prepare scripts FORCE
1717+
%.lst: %.c prepare FORCE
17201718
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1721-
%.s: %.S prepare scripts FORCE
1719+
%.s: %.S prepare FORCE
17221720
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1723-
%.o: %.S prepare scripts FORCE
1721+
%.o: %.S prepare FORCE
17241722
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1725-
%.symtypes: %.c prepare scripts FORCE
1723+
%.symtypes: %.c prepare FORCE
17261724
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
1727-
%.ll: %.c prepare scripts FORCE
1725+
%.ll: %.c prepare FORCE
17281726
$(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
17291727

17301728
# Modules
1731-
/: prepare scripts FORCE
1729+
/: prepare FORCE
17321730
$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
17331731
$(build)=$(build-dir)
17341732
# Make sure the latest headers are built for Documentation
17351733
Documentation/ samples/: headers_install
1736-
%/: prepare scripts FORCE
1734+
%/: prepare FORCE
17371735
$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
17381736
$(build)=$(build-dir)
1739-
%.ko: prepare scripts FORCE
1737+
%.ko: prepare FORCE
17401738
$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
17411739
$(build)=$(build-dir) $(@:.ko=.o)
17421740
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost

0 commit comments

Comments
 (0)