Skip to content

Commit 05ea886

Browse files
djbwtorvalds
authored andcommitted
mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct
When device-dax is operating in huge-page mode we want it to behave like hugetlbfs and report the MMU page mapping size that is being enforced by the vma. Similar to commit 31383c6 "mm, hugetlbfs: introduce ->split() to vm_operations_struct" it would be messy to teach vma_mmu_pagesize() about device-dax page mapping sizes in the same (hstate) way that hugetlbfs communicates this attribute. Instead, these patches introduce a new ->pagesize() vm operation. Link: http://lkml.kernel.org/r/151996254734.27922.15813097401404359642.stgit@dwillia2-desk3.amr.corp.intel.com Signed-off-by: Dan Williams <[email protected]> Reported-by: Jane Chu <[email protected]> Reviewed-by: Andrew Morton <[email protected]> Cc: Benjamin Herrenschmidt <[email protected]> Cc: Michael Ellerman <[email protected]> Cc: Paul Mackerras <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 09135cc commit 05ea886

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

include/linux/mm.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ struct vm_operations_struct {
390390
int (*huge_fault)(struct vm_fault *vmf, enum page_entry_size pe_size);
391391
void (*map_pages)(struct vm_fault *vmf,
392392
pgoff_t start_pgoff, pgoff_t end_pgoff);
393+
unsigned long (*pagesize)(struct vm_area_struct * area);
393394

394395
/* notification that a previously read-only page is about to become
395396
* writable, if an error is returned it will cause a SIGBUS */

mm/hugetlb.c

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -637,14 +637,9 @@ EXPORT_SYMBOL_GPL(linear_hugepage_index);
637637
*/
638638
unsigned long vma_kernel_pagesize(struct vm_area_struct *vma)
639639
{
640-
struct hstate *hstate;
641-
642-
if (!is_vm_hugetlb_page(vma))
643-
return PAGE_SIZE;
644-
645-
hstate = hstate_vma(vma);
646-
647-
return 1UL << huge_page_shift(hstate);
640+
if (vma->vm_ops && vma->vm_ops->pagesize)
641+
return vma->vm_ops->pagesize(vma);
642+
return PAGE_SIZE;
648643
}
649644
EXPORT_SYMBOL_GPL(vma_kernel_pagesize);
650645

@@ -3151,6 +3146,13 @@ static int hugetlb_vm_op_split(struct vm_area_struct *vma, unsigned long addr)
31513146
return 0;
31523147
}
31533148

3149+
static unsigned long hugetlb_vm_op_pagesize(struct vm_area_struct *vma)
3150+
{
3151+
struct hstate *hstate = hstate_vma(vma);
3152+
3153+
return 1UL << huge_page_shift(hstate);
3154+
}
3155+
31543156
/*
31553157
* We cannot handle pagefaults against hugetlb pages at all. They cause
31563158
* handle_mm_fault() to try to instantiate regular-sized pages in the
@@ -3168,6 +3170,7 @@ const struct vm_operations_struct hugetlb_vm_ops = {
31683170
.open = hugetlb_vm_op_open,
31693171
.close = hugetlb_vm_op_close,
31703172
.split = hugetlb_vm_op_split,
3173+
.pagesize = hugetlb_vm_op_pagesize,
31713174
};
31723175

31733176
static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page,

0 commit comments

Comments
 (0)