Skip to content

Commit 05f4f1a

Browse files
fransklavertmlind
authored andcommitted
ARM: OMAP3: vc: fix 'or' always true warning
Fix the warning: arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] As we're toggling both CLKREQ and OFFMODE, we should also be checking OFFMODE. Signed-off-by: Frans Klaver <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 874b300 commit 05f4f1a

File tree

1 file changed

+1
-1
lines changed
  • arch/arm/mach-omap2

1 file changed

+1
-1
lines changed

arch/arm/mach-omap2/vc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm)
300300

301301
val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET);
302302
if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) ||
303-
(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) {
303+
(val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) {
304304
val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL;
305305
val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL;
306306
pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n",

0 commit comments

Comments
 (0)