Skip to content

Commit 0610999

Browse files
jigpuJiri Kosina
authored andcommitted
HID: wacom: Rename wacom ID report ID macros
"INTUOSREAD" and "INTUOSWRITE" are poorly named. These are report IDs for pen ID (proximity) packets. It should be noted that the latter is only used on Intuos/Intuos2 for a second stylus when DualTrack is in use. Signed-off-by: Jason Gerecke <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 5f33f43 commit 0610999

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

drivers/hid/wacom_wac.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ static void wacom_intuos_schedule_prox_event(struct wacom_wac *wacom_wac)
443443
struct hid_report_enum *re;
444444

445445
re = &(wacom->hdev->report_enum[HID_FEATURE_REPORT]);
446-
r = re->report_id_hash[WACOM_REPORT_INTUOSREAD];
446+
r = re->report_id_hash[WACOM_REPORT_INTUOS_ID1];
447447
if (r) {
448448
hid_hw_request(wacom->hdev, r, HID_REQ_GET_REPORT);
449449
}
@@ -1027,8 +1027,8 @@ static int wacom_intuos_irq(struct wacom_wac *wacom)
10271027
int result;
10281028

10291029
if (data[0] != WACOM_REPORT_PENABLED &&
1030-
data[0] != WACOM_REPORT_INTUOSREAD &&
1031-
data[0] != WACOM_REPORT_INTUOSWRITE &&
1030+
data[0] != WACOM_REPORT_INTUOS_ID1 &&
1031+
data[0] != WACOM_REPORT_INTUOS_ID2 &&
10321032
data[0] != WACOM_REPORT_INTUOSPAD &&
10331033
data[0] != WACOM_REPORT_INTUOS_PEN &&
10341034
data[0] != WACOM_REPORT_CINTIQ &&

drivers/hid/wacom_wac.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
/* wacom data packet report IDs */
4848
#define WACOM_REPORT_PENABLED 2
4949
#define WACOM_REPORT_PENABLED_BT 3
50-
#define WACOM_REPORT_INTUOSREAD 5
51-
#define WACOM_REPORT_INTUOSWRITE 6
50+
#define WACOM_REPORT_INTUOS_ID1 5
51+
#define WACOM_REPORT_INTUOS_ID2 6
5252
#define WACOM_REPORT_INTUOSPAD 12
5353
#define WACOM_REPORT_INTUOS5PAD 3
5454
#define WACOM_REPORT_DTUSPAD 21

0 commit comments

Comments
 (0)