Skip to content

Commit 0667483

Browse files
jwrdegoedegregkh
authored andcommitted
libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk
commit 2cfce3a upstream. Commit 184add2 ("libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs. This has lead to several reports of users of that SSD where LPM was working fine and who know have a significantly increased idle power consumption on their laptops. Likely there is another problem on the T450s from the original reporter which gets exposed by the uncore reaching deeper sleep states (higher PC-states) due to LPM being enabled. The problem as reported, a hardfreeze about once a day, already did not sound like it would be caused by LPM and the reports of the SSD working fine confirm this. The original reporter is ok with dropping the quirk. A X250 user has reported the same hard freeze problem and for him the problem went away after unrelated updates, I suspect some GPU driver stack changes fixed things. TL;DR: The original reporters problem were triggered by LPM but not an LPM issue, so drop the quirk for the SSD in question. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1583207 Cc: [email protected] Cc: Richard W.M. Jones <[email protected]> Cc: Lorenzo Dalrio <[email protected]> Reported-by: Lorenzo Dalrio <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Tejun Heo <[email protected]> Acked-by: "Richard W.M. Jones" <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 27c0f1e commit 0667483

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/ata/libata-core.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4543,9 +4543,6 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
45434543
ATA_HORKAGE_ZERO_AFTER_TRIM |
45444544
ATA_HORKAGE_NOLPM, },
45454545

4546-
/* Sandisk devices which are known to not handle LPM well */
4547-
{ "SanDisk SD7UB3Q*G1001", NULL, ATA_HORKAGE_NOLPM, },
4548-
45494546
/* devices that don't properly handle queued TRIM commands */
45504547
{ "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
45514548
ATA_HORKAGE_ZERO_AFTER_TRIM, },

0 commit comments

Comments
 (0)