Skip to content

Commit 06da9f3

Browse files
Kui-Feng LeeMartin KaFai Lau
Kui-Feng Lee
authored and
Martin KaFai Lau
committed
selftests/bpf: Test switching TCP Congestion Control algorithms.
Create a pair of sockets that utilize the congestion control algorithm under a particular name. Then switch up this congestion control algorithm to another implementation and check whether newly created connections using the same cc name now run the new implementation. Also, try to update a link with a struct_ops that is without BPF_F_LINK or with a wrong or different name. These cases should fail due to the violation of assumptions. To update a bpf_link of a struct_ops, it must be replaced with another struct_ops that is identical in type and name and has the BPF_F_LINK flag. The other test case is to create links from the same struct_ops more than once. It makes sure a struct_ops can be used repeatly. Signed-off-by: Kui-Feng Lee <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin KaFai Lau <[email protected]>
1 parent 809a69d commit 06da9f3

File tree

2 files changed

+240
-0
lines changed

2 files changed

+240
-0
lines changed

‎tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c

Lines changed: 160 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "bpf_dctcp.skel.h"
99
#include "bpf_cubic.skel.h"
1010
#include "bpf_tcp_nogpl.skel.h"
11+
#include "tcp_ca_update.skel.h"
1112
#include "bpf_dctcp_release.skel.h"
1213
#include "tcp_ca_write_sk_pacing.skel.h"
1314
#include "tcp_ca_incompl_cong_ops.skel.h"
@@ -381,6 +382,155 @@ static void test_unsupp_cong_op(void)
381382
libbpf_set_print(old_print_fn);
382383
}
383384

385+
static void test_update_ca(void)
386+
{
387+
struct tcp_ca_update *skel;
388+
struct bpf_link *link;
389+
int saved_ca1_cnt;
390+
int err;
391+
392+
skel = tcp_ca_update__open_and_load();
393+
if (!ASSERT_OK_PTR(skel, "open"))
394+
return;
395+
396+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
397+
ASSERT_OK_PTR(link, "attach_struct_ops");
398+
399+
do_test("tcp_ca_update", NULL);
400+
saved_ca1_cnt = skel->bss->ca1_cnt;
401+
ASSERT_GT(saved_ca1_cnt, 0, "ca1_ca1_cnt");
402+
403+
err = bpf_link__update_map(link, skel->maps.ca_update_2);
404+
ASSERT_OK(err, "update_map");
405+
406+
do_test("tcp_ca_update", NULL);
407+
ASSERT_EQ(skel->bss->ca1_cnt, saved_ca1_cnt, "ca2_ca1_cnt");
408+
ASSERT_GT(skel->bss->ca2_cnt, 0, "ca2_ca2_cnt");
409+
410+
bpf_link__destroy(link);
411+
tcp_ca_update__destroy(skel);
412+
}
413+
414+
static void test_update_wrong(void)
415+
{
416+
struct tcp_ca_update *skel;
417+
struct bpf_link *link;
418+
int saved_ca1_cnt;
419+
int err;
420+
421+
skel = tcp_ca_update__open_and_load();
422+
if (!ASSERT_OK_PTR(skel, "open"))
423+
return;
424+
425+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
426+
ASSERT_OK_PTR(link, "attach_struct_ops");
427+
428+
do_test("tcp_ca_update", NULL);
429+
saved_ca1_cnt = skel->bss->ca1_cnt;
430+
ASSERT_GT(saved_ca1_cnt, 0, "ca1_ca1_cnt");
431+
432+
err = bpf_link__update_map(link, skel->maps.ca_wrong);
433+
ASSERT_ERR(err, "update_map");
434+
435+
do_test("tcp_ca_update", NULL);
436+
ASSERT_GT(skel->bss->ca1_cnt, saved_ca1_cnt, "ca2_ca1_cnt");
437+
438+
bpf_link__destroy(link);
439+
tcp_ca_update__destroy(skel);
440+
}
441+
442+
static void test_mixed_links(void)
443+
{
444+
struct tcp_ca_update *skel;
445+
struct bpf_link *link, *link_nl;
446+
int err;
447+
448+
skel = tcp_ca_update__open_and_load();
449+
if (!ASSERT_OK_PTR(skel, "open"))
450+
return;
451+
452+
link_nl = bpf_map__attach_struct_ops(skel->maps.ca_no_link);
453+
ASSERT_OK_PTR(link_nl, "attach_struct_ops_nl");
454+
455+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
456+
ASSERT_OK_PTR(link, "attach_struct_ops");
457+
458+
do_test("tcp_ca_update", NULL);
459+
ASSERT_GT(skel->bss->ca1_cnt, 0, "ca1_ca1_cnt");
460+
461+
err = bpf_link__update_map(link, skel->maps.ca_no_link);
462+
ASSERT_ERR(err, "update_map");
463+
464+
bpf_link__destroy(link);
465+
bpf_link__destroy(link_nl);
466+
tcp_ca_update__destroy(skel);
467+
}
468+
469+
static void test_multi_links(void)
470+
{
471+
struct tcp_ca_update *skel;
472+
struct bpf_link *link;
473+
474+
skel = tcp_ca_update__open_and_load();
475+
if (!ASSERT_OK_PTR(skel, "open"))
476+
return;
477+
478+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
479+
ASSERT_OK_PTR(link, "attach_struct_ops_1st");
480+
bpf_link__destroy(link);
481+
482+
/* A map should be able to be used to create links multiple
483+
* times.
484+
*/
485+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
486+
ASSERT_OK_PTR(link, "attach_struct_ops_2nd");
487+
bpf_link__destroy(link);
488+
489+
tcp_ca_update__destroy(skel);
490+
}
491+
492+
static void test_link_replace(void)
493+
{
494+
DECLARE_LIBBPF_OPTS(bpf_link_update_opts, opts);
495+
struct tcp_ca_update *skel;
496+
struct bpf_link *link;
497+
int err;
498+
499+
skel = tcp_ca_update__open_and_load();
500+
if (!ASSERT_OK_PTR(skel, "open"))
501+
return;
502+
503+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
504+
ASSERT_OK_PTR(link, "attach_struct_ops_1st");
505+
bpf_link__destroy(link);
506+
507+
link = bpf_map__attach_struct_ops(skel->maps.ca_update_2);
508+
ASSERT_OK_PTR(link, "attach_struct_ops_2nd");
509+
510+
/* BPF_F_REPLACE with a wrong old map Fd. It should fail!
511+
*
512+
* With BPF_F_REPLACE, the link should be updated only if the
513+
* old map fd given here matches the map backing the link.
514+
*/
515+
opts.old_map_fd = bpf_map__fd(skel->maps.ca_update_1);
516+
opts.flags = BPF_F_REPLACE;
517+
err = bpf_link_update(bpf_link__fd(link),
518+
bpf_map__fd(skel->maps.ca_update_1),
519+
&opts);
520+
ASSERT_ERR(err, "bpf_link_update_fail");
521+
522+
/* BPF_F_REPLACE with a correct old map Fd. It should success! */
523+
opts.old_map_fd = bpf_map__fd(skel->maps.ca_update_2);
524+
err = bpf_link_update(bpf_link__fd(link),
525+
bpf_map__fd(skel->maps.ca_update_1),
526+
&opts);
527+
ASSERT_OK(err, "bpf_link_update_success");
528+
529+
bpf_link__destroy(link);
530+
531+
tcp_ca_update__destroy(skel);
532+
}
533+
384534
void test_bpf_tcp_ca(void)
385535
{
386536
if (test__start_subtest("dctcp"))
@@ -399,4 +549,14 @@ void test_bpf_tcp_ca(void)
399549
test_incompl_cong_ops();
400550
if (test__start_subtest("unsupp_cong_op"))
401551
test_unsupp_cong_op();
552+
if (test__start_subtest("update_ca"))
553+
test_update_ca();
554+
if (test__start_subtest("update_wrong"))
555+
test_update_wrong();
556+
if (test__start_subtest("mixed_links"))
557+
test_mixed_links();
558+
if (test__start_subtest("multi_links"))
559+
test_multi_links();
560+
if (test__start_subtest("link_replace"))
561+
test_link_replace();
402562
}

‎tools/testing/selftests/bpf/progs/tcp_ca_update.c

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
3+
#include "vmlinux.h"
4+
5+
#include <bpf/bpf_helpers.h>
6+
#include <bpf/bpf_tracing.h>
7+
8+
char _license[] SEC("license") = "GPL";
9+
10+
int ca1_cnt = 0;
11+
int ca2_cnt = 0;
12+
13+
static inline struct tcp_sock *tcp_sk(const struct sock *sk)
14+
{
15+
return (struct tcp_sock *)sk;
16+
}
17+
18+
SEC("struct_ops/ca_update_1_init")
19+
void BPF_PROG(ca_update_1_init, struct sock *sk)
20+
{
21+
ca1_cnt++;
22+
}
23+
24+
SEC("struct_ops/ca_update_2_init")
25+
void BPF_PROG(ca_update_2_init, struct sock *sk)
26+
{
27+
ca2_cnt++;
28+
}
29+
30+
SEC("struct_ops/ca_update_cong_control")
31+
void BPF_PROG(ca_update_cong_control, struct sock *sk,
32+
const struct rate_sample *rs)
33+
{
34+
}
35+
36+
SEC("struct_ops/ca_update_ssthresh")
37+
__u32 BPF_PROG(ca_update_ssthresh, struct sock *sk)
38+
{
39+
return tcp_sk(sk)->snd_ssthresh;
40+
}
41+
42+
SEC("struct_ops/ca_update_undo_cwnd")
43+
__u32 BPF_PROG(ca_update_undo_cwnd, struct sock *sk)
44+
{
45+
return tcp_sk(sk)->snd_cwnd;
46+
}
47+
48+
SEC(".struct_ops.link")
49+
struct tcp_congestion_ops ca_update_1 = {
50+
.init = (void *)ca_update_1_init,
51+
.cong_control = (void *)ca_update_cong_control,
52+
.ssthresh = (void *)ca_update_ssthresh,
53+
.undo_cwnd = (void *)ca_update_undo_cwnd,
54+
.name = "tcp_ca_update",
55+
};
56+
57+
SEC(".struct_ops.link")
58+
struct tcp_congestion_ops ca_update_2 = {
59+
.init = (void *)ca_update_2_init,
60+
.cong_control = (void *)ca_update_cong_control,
61+
.ssthresh = (void *)ca_update_ssthresh,
62+
.undo_cwnd = (void *)ca_update_undo_cwnd,
63+
.name = "tcp_ca_update",
64+
};
65+
66+
SEC(".struct_ops.link")
67+
struct tcp_congestion_ops ca_wrong = {
68+
.cong_control = (void *)ca_update_cong_control,
69+
.ssthresh = (void *)ca_update_ssthresh,
70+
.undo_cwnd = (void *)ca_update_undo_cwnd,
71+
.name = "tcp_ca_wrong",
72+
};
73+
74+
SEC(".struct_ops")
75+
struct tcp_congestion_ops ca_no_link = {
76+
.cong_control = (void *)ca_update_cong_control,
77+
.ssthresh = (void *)ca_update_ssthresh,
78+
.undo_cwnd = (void *)ca_update_undo_cwnd,
79+
.name = "tcp_ca_no_link",
80+
};

0 commit comments

Comments
 (0)