Skip to content

Commit 06e2e88

Browse files
paulburtonralfbaechle
authored andcommitted
MIPS: mark O32+FP64 experimental for now
Commit 597ce17 "MIPS: Support for 64-bit FP with O32 binaries" introduced support for setting Status.FR=1 for O32 binaries with the EF_MIPS_FP64 ELF header flag set. Whilst this flag is currently supported by binutils it does introduce an ABI break within userland. Objects built with EF_MIPS_FP64 cannot be safely linked with those built without it since code in either object may assume behaviour specific to a value of FR. More recently there has been discussion around avoiding further fragmentation of the O32 ABI whilst still allowing the use of FR=1 and features such as MSA which depend upon it. Details of the plan to allow this are still being worked on, and whilst the kernel will need the ability to handle FR=1 with O32 tasks it is unclear what else it may need to provide to a userland which seeks to avoid another ABI break. In order to prevent the proliferation of userland which may rely upon the current EF_MIPS_FP64 behaviour this patch marks the kernel support for it experimental & disables it by default. Under current proposals it is likely that this support can simply be enabled again later, but possibly after the introduction of further interfaces with userland and support for the MIPS R5 UFR feature. Signed-off-by: Paul Burton <[email protected]> Cc: Matthew Fortune <[email protected]> Cc: [email protected] Cc: Paul Burton <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/6549/ Signed-off-by: Ralf Baechle <[email protected]>
1 parent a467109 commit 06e2e88

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

arch/mips/Kconfig

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2353,9 +2353,8 @@ config SECCOMP
23532353
If unsure, say Y. Only embedded should say N here.
23542354

23552355
config MIPS_O32_FP64_SUPPORT
2356-
bool "Support for O32 binaries using 64-bit FP"
2356+
bool "Support for O32 binaries using 64-bit FP (EXPERIMENTAL)"
23572357
depends on 32BIT || MIPS32_O32
2358-
default y
23592358
help
23602359
When this is enabled, the kernel will support use of 64-bit floating
23612360
point registers with binaries using the O32 ABI along with the
@@ -2367,7 +2366,14 @@ config MIPS_O32_FP64_SUPPORT
23672366
of your kernel & potentially improve FP emulation performance by
23682367
saying N here.
23692368

2370-
If unsure, say Y.
2369+
Although binutils currently supports use of this flag the details
2370+
concerning its effect upon the O32 ABI in userland are still being
2371+
worked on. In order to avoid userland becoming dependant upon current
2372+
behaviour before the details have been finalised, this option should
2373+
be considered experimental and only enabled by those working upon
2374+
said details.
2375+
2376+
If unsure, say N.
23712377

23722378
config USE_OF
23732379
bool

0 commit comments

Comments
 (0)