Skip to content

Commit 087c2e3

Browse files
committed
ALSA: hda/via - Disable broken dynamic power control
Since the transition to the generic parser, the actual routes used there don't match always with the assumed static paths in some set_widgets_power_state callbacks. This results in the wrong power setup in the end. As a temporary workaround, we need to disable the calls together with the non-functional dynamic power control enum. Reported-by: Alex Riesen <[email protected]> Cc: <[email protected]> [v3.9] Signed-off-by: Takashi Iwai <[email protected]>
1 parent a0c6d30 commit 087c2e3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

sound/pci/hda/patch_via.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,14 @@ static void vt1708_update_hp_work(struct hda_codec *codec)
231231

232232
static void set_widgets_power_state(struct hda_codec *codec)
233233
{
234+
#if 0 /* FIXME: the assumed connections don't match always with the
235+
* actual routes by the generic parser, so better to disable
236+
* the control for safety.
237+
*/
234238
struct via_spec *spec = codec->spec;
235239
if (spec->set_widgets_power_state)
236240
spec->set_widgets_power_state(codec);
241+
#endif
237242
}
238243

239244
static void update_power_state(struct hda_codec *codec, hda_nid_t nid,

0 commit comments

Comments
 (0)