Skip to content

Commit 088406b

Browse files
bfieldsLinus Torvalds
authored andcommitted
[PATCH] nfsd: fix spurious error return from nfsd_create in async case
Commit 6264d69 modified the nfsd_create() error handling in such a way that nfsd_create will usually return nfserr_perm even when succesful, if the export has the async export option. This introduced a regression that could cause mkdir() to always return a permissions error, even though the directory in question was actually succesfully created. Signed-off-by: J. Bruce Fields <[email protected]> Acked-by: NeilBrown <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 51f65eb commit 088406b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/nfsd/vfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1177,7 +1177,7 @@ nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
11771177
/*
11781178
* Get the dir op function pointer.
11791179
*/
1180-
err = nfserr_perm;
1180+
err = 0;
11811181
switch (type) {
11821182
case S_IFREG:
11831183
host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL);

0 commit comments

Comments
 (0)