Skip to content

Commit 0b6b524

Browse files
committed
ALSA: x86: Don't enable runtime PM as default
Unlike HSW and newer, BYT/CHT devices have no fine control of audio power domain in i915 side. Since there is little gain by runtime PM on BYT/CHT, so far, this commit removes the pm_runtime_enable() call as default. User who still wants the runtime PM may adjust the corresponding sysfs files (power/control and power/autosuspend_delay_ms) appropriately, of course. Signed-off-by: Takashi Iwai <[email protected]>
1 parent 3002b9f commit 0b6b524

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sound/x86/intel_hdmi_audio.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,11 +1809,13 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
18091809
pdata->notify_pending = false;
18101810
spin_unlock_irq(&pdata->lpe_audio_slock);
18111811

1812+
/* runtime PM isn't enabled as default, since it won't save much on
1813+
* BYT/CHT devices; user who want the runtime PM should adjust the
1814+
* power/ontrol and power/autosuspend_delay_ms sysfs entries instead
1815+
*/
18121816
pm_runtime_use_autosuspend(&pdev->dev);
18131817
pm_runtime_mark_last_busy(&pdev->dev);
1814-
18151818
pm_runtime_set_active(&pdev->dev);
1816-
pm_runtime_enable(&pdev->dev);
18171819

18181820
dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
18191821
schedule_work(&ctx->hdmi_audio_wq);

0 commit comments

Comments
 (0)