Skip to content

Commit 0b8e7bb

Browse files
t123yhmripard
authored andcommitted
drm/sun4i: tcon: Set min division of TCON0_DCLK to 1.
The datasheet of V3s (and various other chips) wrote that TCON0_DCLK_DIV can be >= 1 if only dclk is used, and must >= 6 if dclk1 or dclk2 is used. As currently neither dclk1 nor dclk2 is used (no writes to these bits), let's set minimal division to 1. If this minimal division is 6, some common dot clock frequencies can't be produced (e.g. 30MHz will not be possible and will fallback to 25MHz), which is obviously not an expected behaviour. Signed-off-by: Yunhao Tian <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> Link: https://lore.kernel.org/linux-arm-kernel/MN2PR08MB57905AD8A00C08DA219377C989760@MN2PR08MB5790.namprd08.prod.outlook.com/
1 parent 105401b commit 0b8e7bb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/sun4i/sun4i_tcon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
488488

489489
WARN_ON(!tcon->quirks->has_channel_0);
490490

491-
tcon->dclk_min_div = 6;
491+
tcon->dclk_min_div = 1;
492492
tcon->dclk_max_div = 127;
493493
sun4i_tcon0_mode_set_common(tcon, mode);
494494

0 commit comments

Comments
 (0)