Skip to content

Commit 0cb70ee

Browse files
jasowangkuba-moo
authored andcommitted
virtio: rename virtio_config_enabled to virtio_config_core_enabled
Following patch will allow the config interrupt to be disabled by a specific driver via another boolean. So this patch renames virtio_config_enabled and relevant helpers to virtio_config_core_enabled. Cc: Venkat Venkatsubra <[email protected]> Cc: Gia-Khanh Nguyen <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Jason Wang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent d440af3 commit 0cb70ee

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

drivers/virtio/virtio.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ static void __virtio_config_changed(struct virtio_device *dev)
127127
{
128128
struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
129129

130-
if (!dev->config_enabled)
130+
if (!dev->config_core_enabled)
131131
dev->config_change_pending = true;
132132
else if (drv && drv->config_changed)
133133
drv->config_changed(dev);
@@ -143,17 +143,17 @@ void virtio_config_changed(struct virtio_device *dev)
143143
}
144144
EXPORT_SYMBOL_GPL(virtio_config_changed);
145145

146-
static void virtio_config_disable(struct virtio_device *dev)
146+
static void virtio_config_core_disable(struct virtio_device *dev)
147147
{
148148
spin_lock_irq(&dev->config_lock);
149-
dev->config_enabled = false;
149+
dev->config_core_enabled = false;
150150
spin_unlock_irq(&dev->config_lock);
151151
}
152152

153-
static void virtio_config_enable(struct virtio_device *dev)
153+
static void virtio_config_core_enable(struct virtio_device *dev)
154154
{
155155
spin_lock_irq(&dev->config_lock);
156-
dev->config_enabled = true;
156+
dev->config_core_enabled = true;
157157
if (dev->config_change_pending)
158158
__virtio_config_changed(dev);
159159
dev->config_change_pending = false;
@@ -316,7 +316,7 @@ static int virtio_dev_probe(struct device *_d)
316316
if (drv->scan)
317317
drv->scan(dev);
318318

319-
virtio_config_enable(dev);
319+
virtio_config_core_enable(dev);
320320

321321
return 0;
322322

@@ -331,7 +331,7 @@ static void virtio_dev_remove(struct device *_d)
331331
struct virtio_device *dev = dev_to_virtio(_d);
332332
struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
333333

334-
virtio_config_disable(dev);
334+
virtio_config_core_disable(dev);
335335

336336
drv->remove(dev);
337337

@@ -443,7 +443,7 @@ int register_virtio_device(struct virtio_device *dev)
443443
goto out_ida_remove;
444444

445445
spin_lock_init(&dev->config_lock);
446-
dev->config_enabled = false;
446+
dev->config_core_enabled = false;
447447
dev->config_change_pending = false;
448448

449449
INIT_LIST_HEAD(&dev->vqs);
@@ -500,14 +500,14 @@ int virtio_device_freeze(struct virtio_device *dev)
500500
struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
501501
int ret;
502502

503-
virtio_config_disable(dev);
503+
virtio_config_core_disable(dev);
504504

505505
dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED;
506506

507507
if (drv && drv->freeze) {
508508
ret = drv->freeze(dev);
509509
if (ret) {
510-
virtio_config_enable(dev);
510+
virtio_config_core_enable(dev);
511511
return ret;
512512
}
513513
}
@@ -557,7 +557,7 @@ int virtio_device_restore(struct virtio_device *dev)
557557
if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
558558
virtio_device_ready(dev);
559559

560-
virtio_config_enable(dev);
560+
virtio_config_core_enable(dev);
561561

562562
return 0;
563563

include/linux/virtio.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ struct virtio_admin_cmd {
118118
* struct virtio_device - representation of a device using virtio
119119
* @index: unique position on the virtio bus
120120
* @failed: saved value for VIRTIO_CONFIG_S_FAILED bit (for restore)
121-
* @config_enabled: configuration change reporting enabled
121+
* @config_core_enabled: configuration change reporting enabled by core
122122
* @config_change_pending: configuration change reported while disabled
123123
* @config_lock: protects configuration change reporting
124124
* @vqs_list_lock: protects @vqs.
@@ -135,7 +135,7 @@ struct virtio_admin_cmd {
135135
struct virtio_device {
136136
int index;
137137
bool failed;
138-
bool config_enabled;
138+
bool config_core_enabled;
139139
bool config_change_pending;
140140
spinlock_t config_lock;
141141
spinlock_t vqs_list_lock;

0 commit comments

Comments
 (0)