macvtap: correctly free skb during socket destruction

jasowang · davem330 · commit 0d7eacbe6379 · 2016-07-18T22:11:22.000-07:00
We should use kfree_skb() instead of kfree() to free an skb. Fixes: 362899b ("macvtap: switch to use skb array") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
@@ -536,7 +536,7 @@ static void macvtap_sock_destruct(struct sock *sk)
 	struct sk_buff *skb;
 
 	while ((skb = skb_array_consume(&q->skb_array)) != NULL)
-		kfree(skb);
+		kfree_skb(skb);
 }
 
 static int macvtap_open(struct inode *inode, struct file *file)

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ static void macvtap_sock_destruct(struct sock *sk)`
`536`	`536`	`struct sk_buff *skb;`
`537`	`537`
`538`	`538`	`while ((skb = skb_array_consume(&q->skb_array)) != NULL)`
`539`		`- kfree(skb);`
	`539`	`+ kfree_skb(skb);`
`540`	`540`	`}`
`541`	`541`
`542`	`542`	`static int macvtap_open(struct inode inode, struct file file)`