Skip to content

Commit 0da6054

Browse files
jhovolddavem330
authored andcommitted
net: bcmgenet: fix phydev reference leak
Make sure to drop the reference taken by of_phy_find_device() when initialising MOCA PHYs. Fixes: 6ac9de5 ("net: bcmgenet: Register link_update callback for all MoCA PHYs") Signed-off-by: Johan Hovold <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent fd05d7b commit 0da6054

File tree

1 file changed

+3
-1
lines changed
  • drivers/net/ethernet/broadcom/genet

1 file changed

+3
-1
lines changed

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,10 @@ static int bcmgenet_mii_of_init(struct bcmgenet_priv *priv)
542542
/* Make sure we initialize MoCA PHYs with a link down */
543543
if (phy_mode == PHY_INTERFACE_MODE_MOCA) {
544544
phydev = of_phy_find_device(dn);
545-
if (phydev)
545+
if (phydev) {
546546
phydev->link = 0;
547+
put_device(&phydev->mdio.dev);
548+
}
547549
}
548550

549551
return 0;

0 commit comments

Comments
 (0)