irqchip/irq-pic32-evic: Fix bug with external interrupts.

digitalpeer · Marc Zyngier · commit 0de6b9979e2e · 2016-06-02T18:03:50.000+01:00
The wrong external interrupt bits are being set, offset by 1.

Signed-off-by: Joshua Henderson &lt;digitalpeer@digitalpeer.com&gt;
Signed-off-by: Purna Chandra Mandal &lt;purna.mandal@microchip.com&gt;
Signed-off-by: Marc Zyngier &lt;marc.zyngier@arm.com&gt;
diff --git a/drivers/irqchip/irq-pic32-evic.c b/drivers/irqchip/irq-pic32-evic.c
@@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data,
 	/* set polarity for external interrupts only */
 	for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {
 		if (priv->ext_irqs[i] == data->hwirq) {
-			ret = pic32_set_ext_polarity(i + 1, flow_type);
+			ret = pic32_set_ext_polarity(i, flow_type);
 			if (ret)
 				return ret;
 		}

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data,`
`91`	`91`	`/* set polarity for external interrupts only */`
`92`	`92`	`for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {`
`93`	`93`	`if (priv->ext_irqs[i] == data->hwirq) {`
`94`		`- ret = pic32_set_ext_polarity(i + 1, flow_type);`
	`94`	`+ ret = pic32_set_ext_polarity(i, flow_type);`
`95`	`95`	`if (ret)`
`96`	`96`	`return ret;`
`97`	`97`	`}`