Skip to content

Commit 0e0f27d

Browse files
Zach Browndavem330
authored andcommitted
skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace
Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Also changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5bb61cb commit 0e0f27d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

drivers/net/ethernet/marvell/skge.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,7 @@ static const char *skge_pause(enum pause_status status)
10481048
static void skge_link_up(struct skge_port *skge)
10491049
{
10501050
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG),
1051-
LED_BLK_OFF|LED_SYNC_OFF|LED_ON);
1051+
LED_BLK_OFF|LED_SYNC_OFF|LED_REG_ON);
10521052

10531053
netif_carrier_on(skge->netdev);
10541054
netif_wake_queue(skge->netdev);
@@ -1062,7 +1062,7 @@ static void skge_link_up(struct skge_port *skge)
10621062

10631063
static void skge_link_down(struct skge_port *skge)
10641064
{
1065-
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
1065+
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
10661066
netif_carrier_off(skge->netdev);
10671067
netif_stop_queue(skge->netdev);
10681068

@@ -2668,7 +2668,7 @@ static int skge_down(struct net_device *dev)
26682668
if (hw->ports == 1)
26692669
free_irq(hw->pdev->irq, hw);
26702670

2671-
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
2671+
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
26722672
if (is_genesis(hw))
26732673
genesis_stop(skge);
26742674
else

drivers/net/ethernet/marvell/skge.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,8 +662,8 @@ enum {
662662
LED_BLK_OFF = 1<<4, /* Link LED Blinking Off */
663663
LED_SYNC_ON = 1<<3, /* Use Sync Wire to switch LED */
664664
LED_SYNC_OFF = 1<<2, /* Disable Sync Wire Input */
665-
LED_ON = 1<<1, /* switch LED on */
666-
LED_OFF = 1<<0, /* switch LED off */
665+
LED_REG_ON = 1<<1, /* switch LED on */
666+
LED_REG_OFF = 1<<0, /* switch LED off */
667667
};
668668

669669
/* Receive GMAC FIFO (YUKON) */

0 commit comments

Comments
 (0)