Skip to content

Commit 0e574a9

Browse files
Johannes Weinertorvalds
authored andcommitted
mm: memcg: clean up fault accounting
The fault accounting functions have a single, memcg-internal user, so they don't need to be global. In fact, their one-line bodies can be directly folded into the caller. And since faults happen one at a time, use this_cpu_inc() directly instead of this_cpu_add(foo, 1). Signed-off-by: Johannes Weiner <[email protected]> Acked-by: KAMEZAWA Hiroyuki <[email protected]> Acked-by: Michal Hocko <[email protected]> Acked-by: Balbir Singh <[email protected]> Cc: David Rientjes <[email protected]> Cc: Hugh Dickins <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 72835c8 commit 0e574a9

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

mm/memcontrol.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -655,16 +655,6 @@ static void mem_cgroup_swap_statistics(struct mem_cgroup *memcg,
655655
this_cpu_add(memcg->stat->count[MEM_CGROUP_STAT_SWAPOUT], val);
656656
}
657657

658-
void mem_cgroup_pgfault(struct mem_cgroup *memcg, int val)
659-
{
660-
this_cpu_add(memcg->stat->events[MEM_CGROUP_EVENTS_PGFAULT], val);
661-
}
662-
663-
void mem_cgroup_pgmajfault(struct mem_cgroup *memcg, int val)
664-
{
665-
this_cpu_add(memcg->stat->events[MEM_CGROUP_EVENTS_PGMAJFAULT], val);
666-
}
667-
668658
static unsigned long mem_cgroup_read_events(struct mem_cgroup *memcg,
669659
enum mem_cgroup_events_index idx)
670660
{
@@ -978,11 +968,11 @@ void mem_cgroup_count_vm_event(struct mm_struct *mm, enum vm_event_item idx)
978968
goto out;
979969

980970
switch (idx) {
981-
case PGMAJFAULT:
982-
mem_cgroup_pgmajfault(memcg, 1);
983-
break;
984971
case PGFAULT:
985-
mem_cgroup_pgfault(memcg, 1);
972+
this_cpu_inc(memcg->stat->events[MEM_CGROUP_EVENTS_PGFAULT]);
973+
break;
974+
case PGMAJFAULT:
975+
this_cpu_inc(memcg->stat->events[MEM_CGROUP_EVENTS_PGMAJFAULT]);
986976
break;
987977
default:
988978
BUG();

0 commit comments

Comments
 (0)