Skip to content

Commit 0e5cdba

Browse files
westerigregkh
authored andcommitted
Revert "PCI: Add ACS quirk for Intel 300 series"
commit 50ca031 upstream. This reverts f154a71 ("PCI: Add ACS quirk for Intel 300 series"). It turns out that erratum "PCH PCIe* Controller Root Port (ACSCTLR) Appear As Read Only" has been fixed in 300 series chipsets, even though the datasheet [1] claims otherwise. To make ACS work properly on 300 series root ports, revert the faulty commit. [1] https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/300-series-c240-series-chipset-pch-spec-update.pdf Fixes: f154a71 ("PCI: Add ACS quirk for Intel 300 series") Signed-off-by: Mika Westerberg <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Cc: [email protected] # v4.18+ Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent f3765ab commit 0e5cdba

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/pci/quirks.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4388,11 +4388,6 @@ static int pci_quirk_qcom_rp_acs(struct pci_dev *dev, u16 acs_flags)
43884388
*
43894389
* 0x9d10-0x9d1b PCI Express Root port #{1-12}
43904390
*
4391-
* The 300 series chipset suffers from the same bug so include those root
4392-
* ports here as well.
4393-
*
4394-
* 0xa32c-0xa343 PCI Express Root port #{0-24}
4395-
*
43964391
* [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html
43974392
* [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html
43984393
* [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html
@@ -4410,7 +4405,6 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
44104405
case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
44114406
case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
44124407
case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
4413-
case 0xa32c ... 0xa343: /* 300 series */
44144408
return true;
44154409
}
44164410

0 commit comments

Comments
 (0)