Skip to content

Commit 100da4c

Browse files
masahir0ymichal42
authored andcommitted
kbuild: docbook: specify KERNELDOC dependency correctly
It is not a good idea to describe %.xml: %.tmpl FORCE ... and $(BOOKS): $(KERNELDOC) separately. This cannot detect missing template files. For example, add something to DOCBOOKS variable: DOCBOOKS += foobar.xml and run make xmldocs It will succeed even if Documention/DocBook/foobar.tmpl does not exist. Signed-off-by: Masahiro Yamada <[email protected]> Signed-off-by: Michal Marek <[email protected]>
1 parent 6f89b9c commit 100da4c

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

Documentation/DocBook/Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,9 @@ define rule_docproc
8888
) > $(dir $@).$(notdir $@).cmd
8989
endef
9090

91-
%.xml: %.tmpl FORCE
91+
%.xml: %.tmpl $(KERNELDOC) $(DOCPROC) FORCE
9292
$(call if_changed_rule,docproc)
9393

94-
###
95-
# Changes in kernel-doc force a rebuild of all documentation
96-
$(BOOKS): $(KERNELDOC)
97-
9894
# Tell kbuild to always build the programs
9995
always := $(hostprogs-y)
10096

0 commit comments

Comments
 (0)