Skip to content

Commit 10435e0

Browse files
Philipp StannerUwe Kleine-König
authored andcommitted
pwm: Replace deprecated PCI functions
pcim_iomap_table() and pcim_request_regions() have been deprecated in commit e354bb8 ("PCI: Deprecate pcim_iomap_table(), pcim_iomap_regions_request_all()") and commit d140f80 ("PCI: Deprecate pcim_iomap_regions() in favor of pcim_iomap_region()"). Replace these functions with pcim_iomap_region(). Additionally, pass the actual driver names to pcim_iomap_region() instead of the previous pci_name(), since the 'name' parameter should always reflect which driver owns a region. Signed-off-by: Philipp Stanner <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Uwe Kleine-König <[email protected]>
1 parent edc19bd commit 10435e0

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

drivers/pwm/pwm-dwc.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,16 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
6666

6767
pci_set_master(pci);
6868

69-
ret = pcim_iomap_regions(pci, BIT(0), pci_name(pci));
70-
if (ret)
71-
return dev_err_probe(dev, ret, "Failed to iomap PCI BAR\n");
72-
7369
info = (const struct dwc_pwm_info *)id->driver_data;
7470
ddata = devm_kzalloc(dev, struct_size(ddata, chips, info->nr), GFP_KERNEL);
7571
if (!ddata)
7672
return -ENOMEM;
7773

78-
/*
79-
* No need to check for pcim_iomap_table() failure,
80-
* pcim_iomap_regions() already does it for us.
81-
*/
82-
ddata->io_base = pcim_iomap_table(pci)[0];
74+
ddata->io_base = pcim_iomap_region(pci, 0, "pwm-dwc");
75+
if (IS_ERR(ddata->io_base))
76+
return dev_err_probe(dev, PTR_ERR(ddata->io_base),
77+
"Failed to request / iomap PCI BAR\n");
78+
8379
ddata->info = info;
8480

8581
for (idx = 0; idx < ddata->info->nr; idx++) {

drivers/pwm/pwm-lpss-pci.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,20 @@ static int pwm_lpss_probe_pci(struct pci_dev *pdev,
1818
const struct pci_device_id *id)
1919
{
2020
const struct pwm_lpss_boardinfo *info;
21+
void __iomem *io_base;
2122
struct pwm_chip *chip;
2223
int err;
2324

2425
err = pcim_enable_device(pdev);
2526
if (err < 0)
2627
return err;
2728

28-
err = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));
29-
if (err)
30-
return err;
29+
io_base = pcim_iomap_region(pdev, 0, "pwm-lpss");
30+
if (IS_ERR(io_base))
31+
return PTR_ERR(io_base);
3132

3233
info = (struct pwm_lpss_boardinfo *)id->driver_data;
33-
chip = devm_pwm_lpss_probe(&pdev->dev, pcim_iomap_table(pdev)[0], info);
34+
chip = devm_pwm_lpss_probe(&pdev->dev, io_base, info);
3435
if (IS_ERR(chip))
3536
return PTR_ERR(chip);
3637

0 commit comments

Comments
 (0)