Skip to content

Commit 10bdfb5

Browse files
Naoya Horiguchitorvalds
authored andcommitted
pagemap: remove remaining unneeded spin_lock()
Commit 025c5b2 ("thp: optimize away unnecessary page table locking") moves spin_lock() into pmd_trans_huge_lock() in order to avoid locking unless pmd is for thp. So this spin_lock() is a bug. Reported-by: Sasha Levin <[email protected]> Signed-off-by: Naoya Horiguchi <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 8da00ed commit 10bdfb5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/proc/task_mmu.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,6 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
783783

784784
/* find the first VMA at or above 'addr' */
785785
vma = find_vma(walk->mm, addr);
786-
spin_lock(&walk->mm->page_table_lock);
787786
if (pmd_trans_huge_lock(pmd, vma) == 1) {
788787
for (; addr != end; addr += PAGE_SIZE) {
789788
unsigned long offset;

0 commit comments

Comments
 (0)