Skip to content

Commit 10d5702

Browse files
ecsvsimonwunderlich
authored andcommitted
batman-adv: Ignore invalid batadv_iv_gw during netlink send
The function batadv_iv_gw_dump stops the processing loop when batadv_iv_gw_dump_entry returns a non-0 return code. This should only happen when the buffer is full. Otherwise, an empty message may be returned by batadv_gw_dump. This empty message will then stop the netlink dumping of gateway entries. At worst, not a single entry is returned to userspace even when plenty of possible gateways exist. Fixes: efb766a ("batman-adv: add B.A.T.M.A.N. IV bat_gw_dump implementations") Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Simon Wunderlich <[email protected]>
1 parent 3bf2a09 commit 10d5702

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/batman-adv/bat_iv_ogm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2729,7 +2729,7 @@ static int batadv_iv_gw_dump_entry(struct sk_buff *msg, u32 portid, u32 seq,
27292729
struct batadv_neigh_ifinfo *router_ifinfo = NULL;
27302730
struct batadv_neigh_node *router;
27312731
struct batadv_gw_node *curr_gw;
2732-
int ret = -EINVAL;
2732+
int ret = 0;
27332733
void *hdr;
27342734

27352735
router = batadv_orig_router_get(gw_node->orig_node, BATADV_IF_DEFAULT);

0 commit comments

Comments
 (0)