Skip to content

Commit 11f33a6

Browse files
ribaldalinusw
authored andcommitted
gpiolib: Fix NULL pointer deference
Under some circumstances, a gpiochip might be half cleaned from the gpio_device list. This patch makes sure that the chip pointer is still valid, before calling the match function. [ 104.088296] BUG: unable to handle kernel NULL pointer dereference at 0000000000000090 [ 104.089772] IP: [<ffffffff813d2045>] of_gpiochip_find_and_xlate+0x15/0x80 [ 104.128273] Call Trace: [ 104.129802] [<ffffffff813d2030>] ? of_parse_own_gpio+0x1f0/0x1f0 [ 104.131353] [<ffffffff813cd910>] gpiochip_find+0x60/0x90 [ 104.132868] [<ffffffff813d21ba>] of_get_named_gpiod_flags+0x9a/0x120 ... [ 104.141586] [<ffffffff8163d12b>] gpio_led_probe+0x11b/0x360 Cc: [email protected] Signed-off-by: Ricardo Ribalda Delgado <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 0f84f29 commit 11f33a6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpio/gpiolib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ struct gpio_chip *gpiochip_find(void *data,
869869

870870
spin_lock_irqsave(&gpio_lock, flags);
871871
list_for_each_entry(gdev, &gpio_devices, list)
872-
if (match(gdev->chip, data))
872+
if (gdev->chip && match(gdev->chip, data))
873873
break;
874874

875875
/* No match? */

0 commit comments

Comments
 (0)